Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sqlite: 3.20.1 -> 3.21.0 #30927

Merged
merged 1 commit into from Oct 30, 2017
Merged

sqlite: 3.20.1 -> 3.21.0 #30927

merged 1 commit into from Oct 30, 2017

Conversation

mimame
Copy link
Member

@mimame mimame commented Oct 29, 2017 •
edited by grahamc

Motivation for this change

Update sqlite to the last version in staging
https://www.sqlite.org/releaselog/3_21_0.html

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@grahamc
Copy link
Member

grahamc commented Oct 29, 2017

@GrahamcOfBorg sqlite

@7c6f434c
Copy link
Member

@grahamc I would actually say that Nix would be a natural thing to test for an sqlite bump — or are you just verifying that staging requests get processed correctly?

@dezgeg dezgeg mentioned this pull request Oct 30, 2017
Closed
74 tasks
@vcunat vcunat self-assigned this Oct 30, 2017
@vcunat
Copy link
Member

vcunat commented Oct 30, 2017

perl-DBD-SQLite-1.50 fails some tests, so it won't get to building nixStable, but nixUnstable builds OK.

@vcunat vcunat merged commit 51ade42 into NixOS:staging Oct 30, 2017
vcunat added a commit that referenced this pull request Oct 30, 2017
@vcunat
Merge #30927: sqlite: 3.20.1 -> 3.21.0
949db25 
Includes a fix for CVE-2017-15286.
vcunat added a commit that referenced this pull request Oct 31, 2017
@vcunat
perl-DBD-SQLite: 1.50 -> 1.54
5618691 
- This fixes tests after sqlite update, also tested via nixStable
  and via building some other perl reverse dependencies.
- The patch was conflicting due to upstream changes,
  but those changes allowed us to minimize the patch.
- meta from nix-generate-from-cpan
/cc #30927.
@vcunat
Copy link
Member

vcunat commented Oct 31, 2017

Perl seems OK after 5618691.

vcunat added a commit that referenced this pull request Nov 1, 2017
@vcunat
Merge #30927: sqlite: 3.20.0 -> 3.21.0
cfd1693 
Includes a fix for CVE-2017-15286.

(cherry picked from commit 949db25)
vcunat added a commit that referenced this pull request Nov 1, 2017
@vcunat
perl-DBD-SQLite: 1.50 -> 1.54
7f8869e 
- This fixes tests after sqlite update, also tested via nixStable
  and via building some other perl reverse dependencies.
- The patch was conflicting due to upstream changes,
  but those changes allowed us to minimize the patch.
- meta from nix-generate-from-cpan
/cc #30927.

(cherry picked from commit 5618691)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@vcunat vcunat

Labels
1.severity: mass-darwin-rebuild 1.severity: mass-rebuild 1.severity: security 10.rebuild-darwin: 501+ 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@mimame @grahamc @7c6f434c @vcunat @FRidh @GrahamcOfBorg