rustup: patch and update #30941
Merged
rustup: patch and update #30941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested and verified on macOS Sierra 10.12.6 ✅ Fixes issue I've been having on latest nixpkgs-unstable which has a pretty outdated rustup - thank you @ljli ! Seems the failing Travis Xcode build is a timeout, works fine on my machine. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can't run executables without setting the right interpreter on NixOS. That renders rustup pretty useless out of the box. The previous solution was to patch rustup to execute binaries by invoking the dynamic linker with the binary as an argument. That works but confuses rustc/cargo which use /proc/self/exe to lookup the standard library path (#25863). The new patch causes rustup to patch the right dynamic loader directly into the binaries after downloading them via patchelf.
Other than that I've updated to the current git HEAD which was necessary to work around #30742.
I've tested this with nightly, beta and stable toolchains, rebased on top of master from a few days ago.