Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nzbget.service override nzbget.conf broken paths with current derivation #30943

Merged
merged 1 commit into from Nov 11, 2017
Merged

nzbget.service override nzbget.conf broken paths with current derivation #30943

merged 1 commit into from Nov 11, 2017

Conversation

csingley
Copy link
Contributor

Motivation for this change

Clean rework of this ugly nzbget bugfix, with commits squashed & extraneous commits removed. Sorry about that.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@c0bw3b
Copy link
Contributor

c0bw3b commented Nov 10, 2017

@csingley for final review

( follow up to #30144 )

@c0bw3b c0bw3b self-assigned this Nov 10, 2017
@csingley
Copy link
Contributor Author

Yes, this is right.

@c0bw3b
Copy link
Contributor

c0bw3b commented Nov 10, 2017

Phew I wanted to ping @fadenb too actually but thanks :)

@c0bw3b
Copy link
Contributor

c0bw3b commented Nov 11, 2017

Well he already approved the changes on the previous PR so let's not stall this longer.

@c0bw3b c0bw3b merged commit 1503409 into NixOS:master Nov 11, 2017
@fadenb fadenb mentioned this pull request Aug 13, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@c0bw3b c0bw3b

Labels
8.has: module (update)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@csingley @c0bw3b