Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bchunk: 1.2.0 -> 1.2.2 #31634

Merged
merged 1 commit into from Nov 14, 2017
Merged

bchunk: 1.2.0 -> 1.2.2 #31634

merged 1 commit into from Nov 14, 2017

Conversation

lukateras
Copy link
Member

Motivation for this change

Security patches have been merged by upstream: http://he.fi/bchunk/
It also includes a useful Debian patch that fixes multi-track conversions.

For discussion, see: extramaster/bchunk#2 (comment)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@grahamc
Copy link
Member

grahamc commented Nov 13, 2017

@GrahamcOfBorg build bchunk

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failure for system: x86_64-darwin

these derivations will be built:
  /nix/store/1ynccc19mqfaicy517n8lawapvv1fyrs-bchunk-1.2.2.tar.gz.drv
  /nix/store/wxrjpcyq5i02dwk5xb023f6h12b75z7d-bchunk-1.2.2.drv
error: derivation '/nix/store/1ynccc19mqfaicy517n8lawapvv1fyrs-bchunk-1.2.2.tar.gz.drv' requested impure path '/System/Library/Frameworks/CoreFoundation.framework/CoreFoundation', but it was not in allowed-impure-host-deps

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success for system: x86_64-linux

gcc  -o bchunk bchunk.o
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/xgnpmsapz8jkhmwj1cfwbaw09j36ha3v-bchunk-1.2.2
shrinking /nix/store/xgnpmsapz8jkhmwj1cfwbaw09j36ha3v-bchunk-1.2.2/bin/bchunk
gzipping man pages under /nix/store/xgnpmsapz8jkhmwj1cfwbaw09j36ha3v-bchunk-1.2.2/share/man/
stripping (with flags -S) in /nix/store/xgnpmsapz8jkhmwj1cfwbaw09j36ha3v-bchunk-1.2.2/bin 
patching script interpreter paths in /nix/store/xgnpmsapz8jkhmwj1cfwbaw09j36ha3v-bchunk-1.2.2
checking for references to /tmp/nix-build-bchunk-1.2.2.drv-0 in /nix/store/xgnpmsapz8jkhmwj1cfwbaw09j36ha3v-bchunk-1.2.2...
/nix/store/xgnpmsapz8jkhmwj1cfwbaw09j36ha3v-bchunk-1.2.2

@fpletz fpletz merged commit f6ad758 into NixOS:master Nov 14, 2017
@lukateras lukateras deleted the bchunk/1.2.2 branch December 18, 2017 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants