jfbview: remove mujs and no-longer-necessary patch #31629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mujs is only required when older versions of mupdf are used, but we have a more recent one in nixpkgs.
|
Would you like to be able to call borg, @lheckemann? |
|
@GrahamcOfBorg build jfbview |
GrahamcOfBorg
approved these changes
Nov 13, 2017
There was a problem hiding this comment.
Success for system: x86_64-linux
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/9xwf10di373bzzjvb6xbn96qwjlyd6g9-jfbview-0.5.4
shrinking /nix/store/9xwf10di373bzzjvb6xbn96qwjlyd6g9-jfbview-0.5.4/bin/jpdfgrep
shrinking /nix/store/9xwf10di373bzzjvb6xbn96qwjlyd6g9-jfbview-0.5.4/bin/jfbview
shrinking /nix/store/9xwf10di373bzzjvb6xbn96qwjlyd6g9-jfbview-0.5.4/bin/jpdfcat
stripping (with flags -S) in /nix/store/9xwf10di373bzzjvb6xbn96qwjlyd6g9-jfbview-0.5.4/bin
patching script interpreter paths in /nix/store/9xwf10di373bzzjvb6xbn96qwjlyd6g9-jfbview-0.5.4
checking for references to /tmp/nix-build-jfbview-0.5.4.drv-0 in /nix/store/9xwf10di373bzzjvb6xbn96qwjlyd6g9-jfbview-0.5.4...
/nix/store/9xwf10di373bzzjvb6xbn96qwjlyd6g9-jfbview-0.5.4
There was a problem hiding this comment.
Failure for system: x86_64-darwin
error: Package ‘jfbview-0.5.4’ in /tmp/nix-ofborg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/31629/pkgs/os-specific/linux/jfbview/default.nix:53 is not supported on ‘x86_64-darwin’, refusing to evaluate.
a) For `nixos-rebuild` you can set
{ nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.
b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
{ allowBroken = true; }
to ~/.config/nixpkgs/config.nix.
That would be awesome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
mujs is only required when older versions of mupdf are used, but
we have a more recent one in nixpkgs.
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)