prometheus-surfboard-exporter: init at 2.0.0 #31645

disassembler · 2017-11-14T04:17:21Z

Motivation for this change

Haven't tested the nixos module yet (will try to tomorrow), but I tested running the exporter standalone and a curl of the metric page got me all my surfboard cable modem stats.

Things done

Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- other Linux distributions
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Fits CONTRIBUTING.md.

fpletz

Code looks fine to me. Thanks!

Mic92 · 2017-11-14T15:46:06Z

nitpick for commit message:

nixos/prometheus-surfboard-exporter: add service

Mic92 · 2017-11-14T15:49:39Z

nixos/modules/services/monitoring/prometheus/surfboard-exporter.nix

+        User = "nobody";
+        Restart = "always";
+        PrivateTmp = true;
+        WorkingDirectory = /tmp;


Does this application creates temporary files securely? There might be other applications racing for /tmp. Also a dedicated user different from nobody would be useful. Unfortunately we do not have the latest systemd release yet. Otherwise runtime directories could be created automatically for DynamicUser=true.

disassembler · 2017-11-15T04:37:12Z

Looking at the code, doesn't look like it writes any files. Everything is stdout or the http socket opened. I've removed the work dir and private tmp attributes. I also fixed the commit message on service commit to prefix with nixos/

Mic92 · 2017-11-15T12:41:34Z

nixos/modules/services/monitoring/prometheus/surfboard-exporter.nix

+      unitConfig.Documentation = "https://github.com/ipstatic/surfboard_exporter";
+      wantedBy = [ "multi-user.target" ];
+      serviceConfig = {
+        User = "nobody";


The following should also work here then:

DynamicUser = "yes";

instead of "nobody".

orivej · 2017-11-17T20:06:32Z

pkgs/servers/monitoring/prometheus/surfboard-exporter.nix

+buildGoPackage rec {
+  name = "surfboard_exporter-${version}";
+  version = "2.0.0";
+  rev = version;


This line is redundant.

WilliButz · 2018-04-18T23:09:46Z

@disassembler I adjusted the commit that adds the module, to work with the new prometheus exporters module (and also rebased this on the current master).

Mic92 · 2018-04-21T10:15:24Z

@WilliButz can you open a pull request?

WilliButz · 2018-04-21T10:23:43Z

@Mic92 sure if that's okay with @disassembler I open one in the next days.

GrahamcOfBorg · 2018-05-01T21:03:41Z

Success on x86_64-linux (full log)

Attempted: prometheus-surfboard-exporter

Partial log (click to expand)

strip is /nix/store/j75dgadrff2d1fyc4fczmcgqkid2imdx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/x9d90m3pyqsdq73dkrx3iq8yq7p1isqb-surfboard_exporter-2.0.0-bin/bin
patching script interpreter paths in /nix/store/x9d90m3pyqsdq73dkrx3iq8yq7p1isqb-surfboard_exporter-2.0.0-bin
checking for references to /build in /nix/store/x9d90m3pyqsdq73dkrx3iq8yq7p1isqb-surfboard_exporter-2.0.0-bin...
shrinking RPATHs of ELF executables and libraries in /nix/store/xjnikwhsq09fk262pcjfay797wxv67mr-surfboard_exporter-2.0.0
strip is /nix/store/j75dgadrff2d1fyc4fczmcgqkid2imdx-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/xjnikwhsq09fk262pcjfay797wxv67mr-surfboard_exporter-2.0.0
/nix/store/xjnikwhsq09fk262pcjfay797wxv67mr-surfboard_exporter-2.0.0/share/go/src/github.com/ipstatic/surfboard_exporter/after_success.sh: interpreter directive changed from "/bin/bash" to "/nix/store/xn5gv3lpfy91yvfy9b0i7klfcxh9xskz-bash-4.4-p19/bin/bash"
checking for references to /build in /nix/store/xjnikwhsq09fk262pcjfay797wxv67mr-surfboard_exporter-2.0.0...
/nix/store/x9d90m3pyqsdq73dkrx3iq8yq7p1isqb-surfboard_exporter-2.0.0-bin

GrahamcOfBorg · 2018-05-01T21:05:33Z

Success on x86_64-darwin (full log)

Attempted: prometheus-surfboard-exporter

Partial log (click to expand)

/private/tmp/nix-build-surfboard_exporter-2.0.0.drv-0/go /private/tmp/nix-build-surfboard_exporter-2.0.0.drv-0
/private/tmp/nix-build-surfboard_exporter-2.0.0.drv-0
post-installation fixup
strip is /nix/store/kdff2gim6417493yha769kh00n63lnrw-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/zbix4n1ipswnya1l7shp67r0d9ipwq53-surfboard_exporter-2.0.0-bin/bin
patching script interpreter paths in /nix/store/zbix4n1ipswnya1l7shp67r0d9ipwq53-surfboard_exporter-2.0.0-bin
strip is /nix/store/kdff2gim6417493yha769kh00n63lnrw-cctools-binutils-darwin/bin/strip
patching script interpreter paths in /nix/store/qy8ck7rf6prk1zc98p04c1naill576xc-surfboard_exporter-2.0.0
/nix/store/qy8ck7rf6prk1zc98p04c1naill576xc-surfboard_exporter-2.0.0/share/go/src/github.com/ipstatic/surfboard_exporter/after_success.sh: interpreter directive changed from "/bin/bash" to "/nix/store/r8bx3qf1bpncb14i9gzma4vr089pc3pv-bash-4.4-p19/bin/bash"
/nix/store/zbix4n1ipswnya1l7shp67r0d9ipwq53-surfboard_exporter-2.0.0-bin

GrahamcOfBorg · 2018-05-01T21:08:41Z

Success on aarch64-linux (full log)

Attempted: prometheus-surfboard-exporter

Partial log (click to expand)

strip is /nix/store/gp7fylxwn18b7pl2c18ks89hsiaxyfvf-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/n34lzfiky5aviycxfy5g27azgnrj5qpr-surfboard_exporter-2.0.0-bin/bin
patching script interpreter paths in /nix/store/n34lzfiky5aviycxfy5g27azgnrj5qpr-surfboard_exporter-2.0.0-bin
checking for references to /build in /nix/store/n34lzfiky5aviycxfy5g27azgnrj5qpr-surfboard_exporter-2.0.0-bin...
shrinking RPATHs of ELF executables and libraries in /nix/store/5anw43shi54yjz9x2h8c6xgmfa7xgvna-surfboard_exporter-2.0.0
strip is /nix/store/gp7fylxwn18b7pl2c18ks89hsiaxyfvf-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/5anw43shi54yjz9x2h8c6xgmfa7xgvna-surfboard_exporter-2.0.0
/nix/store/5anw43shi54yjz9x2h8c6xgmfa7xgvna-surfboard_exporter-2.0.0/share/go/src/github.com/ipstatic/surfboard_exporter/after_success.sh: interpreter directive changed from "/bin/bash" to "/nix/store/a4qslf0yfs44mhnbagarn232sjnckhy0-bash-4.4-p19/bin/bash"
checking for references to /build in /nix/store/5anw43shi54yjz9x2h8c6xgmfa7xgvna-surfboard_exporter-2.0.0...
/nix/store/n34lzfiky5aviycxfy5g27azgnrj5qpr-surfboard_exporter-2.0.0-bin

GrahamcOfBorg added 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Nov 14, 2017

fpletz approved these changes Nov 14, 2017

View reviewed changes

disassembler force-pushed the surfboard branch from 851ebf0 to d566c9d Compare November 14, 2017 13:20

Mic92 reviewed Nov 14, 2017

View reviewed changes

c0bw3b added 8.has: module (new) 8.has: package (new) labels Nov 14, 2017

disassembler force-pushed the surfboard branch from d566c9d to f9e5d71 Compare November 15, 2017 04:35

Mic92 reviewed Nov 15, 2017

View reviewed changes

disassembler force-pushed the surfboard branch from f9e5d71 to 3fd0aee Compare November 15, 2017 13:09

orivej approved these changes Nov 17, 2017

View reviewed changes

orivej reviewed Nov 17, 2017

View reviewed changes

WilliButz force-pushed the surfboard branch from 3fd0aee to a4ab9b3 Compare May 1, 2018 20:38

GrahamcOfBorg added 6.topic: nixos 8.has: module (update) labels May 1, 2018

Samuel Leathers added 2 commits May 1, 2018 22:46

prometheus-surfboard-exporter: init at 2.0.0

0ea108c

nixos/prometheus-surfboard-exporter: add new module

56023ac

WilliButz force-pushed the surfboard branch from a4ab9b3 to 56023ac Compare May 1, 2018 20:47

globin merged commit 78f09c9 into NixOS:master May 2, 2018

disassembler deleted the surfboard branch May 2, 2018 14:21

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

prometheus-surfboard-exporter: init at 2.0.0 #31645

prometheus-surfboard-exporter: init at 2.0.0 #31645

disassembler commented Nov 14, 2017 •

edited

fpletz left a comment

Mic92 commented Nov 14, 2017

Mic92 Nov 14, 2017 •

edited

disassembler commented Nov 15, 2017

Mic92 Nov 15, 2017 •

edited

orivej Nov 17, 2017

WilliButz commented Apr 18, 2018

Mic92 commented Apr 21, 2018

WilliButz commented Apr 21, 2018

GrahamcOfBorg commented May 1, 2018

GrahamcOfBorg commented May 1, 2018

GrahamcOfBorg commented May 1, 2018

prometheus-surfboard-exporter: init at 2.0.0 #31645

prometheus-surfboard-exporter: init at 2.0.0 #31645

Conversation

disassembler commented Nov 14, 2017 • edited

Motivation for this change

Things done

fpletz left a comment

Choose a reason for hiding this comment

Mic92 commented Nov 14, 2017

Mic92 Nov 14, 2017 • edited

Choose a reason for hiding this comment

disassembler commented Nov 15, 2017

Mic92 Nov 15, 2017 • edited

Choose a reason for hiding this comment

orivej Nov 17, 2017

Choose a reason for hiding this comment

WilliButz commented Apr 18, 2018

Mic92 commented Apr 21, 2018

WilliButz commented Apr 21, 2018

GrahamcOfBorg commented May 1, 2018

GrahamcOfBorg commented May 1, 2018

GrahamcOfBorg commented May 1, 2018

disassembler commented Nov 14, 2017 •

edited

Mic92 Nov 14, 2017 •

edited

Mic92 Nov 15, 2017 •

edited