mysql module: fix flaky check #31641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comparing packages via equality will lead to different results when package and module are from different `nixpkgs` checkouts. Also, because MariaDB is actually supported, added a note to option description to make this knowledge more discover-able.
fpletz
approved these changes
Nov 14, 2017
fpletz
approved these changes
Nov 14, 2017
There was a problem hiding this comment.
Thanks a lot for the fix! Looks fine to me but let's wait for @florianjacob to chime in. ;)
florianjacob
approved these changes
Nov 15, 2017
| @@ -7,6 +7,11 @@ let | |||
| cfg = config.services.mysql; | |||
|
|
|||
| mysql = cfg.package; | |||
|
|
|||
| isMariaDB = | |||
There was a problem hiding this comment.
Very well expressed, better than what I could have come up with. 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Comparing packages via equality will lead to different results when package and module are from different
nixpkgscheckouts. See #29387 (comment)Also, because MariaDB is actually supported, added a note to option description to make this knowledge more discover-able. In particular, https://nixos.org/nixos/options.html#mariadb currently shows zero results, but that is wrong, because
pkgs.mysqlis actuallypkgs.mariadb.ping @fpletz
call for test @florianjacob
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)