services.postgres: fix quoting in the description of superUser
#31630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`nixos-option` evals the description and the '`' is used to define shell commands. Due to this, the following error appears: ``` $ nixos-option services.postgresql.superUser Value: "root" Default: "root" Description: /run/current-system/sw/bin/nixos-option: line 294: root: command not found /run/current-system/sw/bin/nixos-option: line 294: postgres: command not found NixOS traditionally used as superuser, most other distros use . From 17.09 we also try to follow this standard. Internal since changing this value would lead to breakage while setting up databases. ```
|
We should definitely also fix nixos-option. |
|
Backporteed in 165dc67 |
|
@grahamc ok, will open a PR for that in the next time :) |
Ma27
added a commit
to Ma27/nixpkgs
that referenced
this pull request
Nov 14, 2017
8 tasks
nbp
pushed a commit
that referenced
this pull request
Nov 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: instead of this we could also quote strings in
nixos-optionproperly, however I'm not sure if the issue I experienced is actually expected behavior.Motivation for this change
nixos-optionevals the description and the '`' is used todefine shell commands.
Due to this, the following error appears:
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)