Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plex: 1.9.5 -> 1.9.7 #31632

Merged
merged 1 commit into from Nov 13, 2017
Merged

plex: 1.9.5 -> 1.9.7 #31632

merged 1 commit into from Nov 13, 2017

Conversation

bflyblue
Copy link
Contributor

@bflyblue bflyblue commented Nov 13, 2017

Motivation for this change

New version of plex released.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@grahamc
Copy link
Member

grahamc commented Nov 13, 2017

@GrahamcOfBorg build plex

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failure for system: x86_64-linux

error: Package ‘plex-1.9.7.4441’ in /var/lib/gc-of-borg/.nix-test-rs/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/31632/pkgs/servers/plex/default.nix:78 has an unfree license (‘unfree’), refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.

@LnL7
Copy link
Member

LnL7 commented Nov 13, 2017

@bflyblue this is the plex pass version, we can't include that in nixpkgs.

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failure for system: x86_64-darwin

error: Package ‘plex-1.9.7.4441’ in /tmp/nix-ofborg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/31632/pkgs/servers/plex/default.nix:78 has an unfree license (‘unfree’), refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.

@grahamc grahamc merged commit a81bd24 into NixOS:master Nov 13, 2017
@grahamc
Copy link
Member

grahamc commented Nov 13, 2017

Ack!!! Sorry @LnL7, I missed your comment. Reverted here: #31635

How could you tell it was Pass?

Sorry @bflyblue, we'll have to try this again in a different PR.

@LnL7
Copy link
Member

LnL7 commented Nov 14, 2017

Updating to 1.9.6 is fine, you can toggle it on the download page to get the public version.

@bflyblue
Copy link
Contributor Author

Ok that's embarassing, I thought I had turned off Pass versions. I'll be more careful in future and submit a new PR for 1.9.6!

@bflyblue bflyblue deleted the plex-1.9.7.4441 branch November 14, 2017 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants