Skip to content

i3status-rust: init at 0.9.0.2017-11-09 #31626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 17, 2017
Merged

i3status-rust: init at 0.9.0.2017-11-09 #31626

merged 1 commit into from
Nov 17, 2017
+29 −0

Conversation

backuitist
Copy link
Contributor

@backuitist backuitist commented Nov 13, 2017 •
edited
Loading

Motivation for this change

New bar for i3.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@backuitist
Copy link
Contributor Author

backuitist commented Nov 13, 2017 •
edited
Loading

A few things:

  • not sure about the maintainer as I don't know that much about Nix
  • it would be good to be able to add the font-awesome-ttf font to the global fonts, but I have no idea if this is possible?
  • i've added a version which does not reflect any release (as the application has not been released yet).

@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Nov 13, 2017
grahamc
grahamc reviewed Nov 13, 2017
View reviewed changes
pkgs/applications/window-managers/i3/status-rust.nix Outdated
description = "Very resource-friendly and feature-rich replacement for i3status, written in Rust";
homepage = https://github.com/greshake/i3status-rust;
license = licenses.gpl3;
maintainers = [ maintainers.tailhook ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you volunteering @tailhook as the maintainer? Generally we'd ask you add yourself to the maintainer list (in lib/maintainers.nix) and put your own name here :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was probably copied from another package :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right this was taken from the manual: https://nixos.org/nixpkgs/manual/#users-guide-to-the-rust-infrastructure
But as I said in my previous comment, I can put my name but I'm not sure I'll be that good of a maintainer ;)
Any idea about the fonts (2nd question)?

@grahamc
Copy link
Member

grahamc commented Nov 13, 2017 •
edited by LnL7
Loading

@GrahamcOfBorg build i3status-rust

GrahamcOfBorg
GrahamcOfBorg approved these changes Nov 13, 2017
View reviewed changes
Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success for system: x86_64-linux

cp: -r not specified; omitting directory 'target/release/deps'
cp: -r not specified; omitting directory 'target/release/build'
cp: -r not specified; omitting directory 'target/release/.fingerprint'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/wr687fskhnpbs1k12l1yg8ysj56i469h-i3status-rust-0.0.1
shrinking /nix/store/wr687fskhnpbs1k12l1yg8ysj56i469h-i3status-rust-0.0.1/bin/i3status-rs
stripping (with flags -S) in /nix/store/wr687fskhnpbs1k12l1yg8ysj56i469h-i3status-rust-0.0.1/bin 
patching script interpreter paths in /nix/store/wr687fskhnpbs1k12l1yg8ysj56i469h-i3status-rust-0.0.1
checking for references to /tmp/nix-build-i3status-rust-0.0.1.drv-0 in /nix/store/wr687fskhnpbs1k12l1yg8ysj56i469h-i3status-rust-0.0.1...
/nix/store/wr687fskhnpbs1k12l1yg8ysj56i469h-i3status-rust-0.0.1

GrahamcOfBorg
GrahamcOfBorg reviewed Nov 13, 2017
View reviewed changes
Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failure for system: x86_64-darwin

  /nix/store/yp374lzwx3wp180yjam44cj4wszl4634-cargo-vendor-0.1.12.drv
  /nix/store/hs4b799i53y0y2l8fnqpavviz6b18asq-i3status-rust-0.0.1-vendor.drv
  /nix/store/29r28vyz48s8aprzzplcq4mi58ql6nbn-i3status-rust-0.0.1.drv
these paths will be fetched (2.84 MiB download, 3.45 MiB unpacked):
  /nix/store/gagdi95vrbl1ddjavlcvr19d430ndc14-dbus-1.10.24-dev
  /nix/store/j6rpjn6m6dpg3x3pn3y1lcrrw6qawf69-cargo-vendor-0.1.12-x86_64-apple-darwin.tar.gz
  /nix/store/l49qg8v2zi5dg6aklqaz518ay6jyw9lw-dbus-1.10.24
  /nix/store/r5j5xdxafbp2ciyx4pmza71mg42gxjrh-dbus-1.10.24-lib
copying path '/nix/store/r5j5xdxafbp2ciyx4pmza71mg42gxjrh-dbus-1.10.24-lib' from 'https://cache.nixos.org'...
error: derivation '/nix/store/sri8wjxxzdz8m0svwvk16xlq5mxhvy68-source.drv' requested impure path '/System/Library/Frameworks/CoreFoundation.framework/CoreFoundation', but it was not in allowed-impure-host-deps

@LnL7
Copy link
Member

LnL7 commented Nov 14, 2017

@GrahamcOfBorg build i3status-rust

GrahamcOfBorg
GrahamcOfBorg reviewed Nov 14, 2017
View reviewed changes
Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failure for system: x86_64-darwin

  /nix/store/sri8wjxxzdz8m0svwvk16xlq5mxhvy68-source.drv
  /nix/store/yp374lzwx3wp180yjam44cj4wszl4634-cargo-vendor-0.1.12.drv
  /nix/store/hs4b799i53y0y2l8fnqpavviz6b18asq-i3status-rust-0.0.1-vendor.drv
  /nix/store/29r28vyz48s8aprzzplcq4mi58ql6nbn-i3status-rust-0.0.1.drv
these paths will be fetched (2.73 MiB download, 3.13 MiB unpacked):
  /nix/store/gagdi95vrbl1ddjavlcvr19d430ndc14-dbus-1.10.24-dev
  /nix/store/j6rpjn6m6dpg3x3pn3y1lcrrw6qawf69-cargo-vendor-0.1.12-x86_64-apple-darwin.tar.gz
  /nix/store/l49qg8v2zi5dg6aklqaz518ay6jyw9lw-dbus-1.10.24
copying path '/nix/store/l49qg8v2zi5dg6aklqaz518ay6jyw9lw-dbus-1.10.24' from 'https://cache.nixos.org'...
error: a 'x86_64-darwin' is required to build '/nix/store/sri8wjxxzdz8m0svwvk16xlq5mxhvy68-source.drv', but I am a 'x86_64-linux'

@LnL7
Copy link
Member

LnL7 commented Nov 14, 2017

@GrahamcOfBorg build i3status-rust

GrahamcOfBorg
GrahamcOfBorg reviewed Nov 14, 2017
View reviewed changes
Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failure for system: x86_64-darwin



error: aborting due to previous error

error: Could not compile `i3status-rs`.

To learn more, run the command again with --verbose.
builder for '/nix/store/rzifgpdfmbwsy34vq2sh60lvd949kkzk-i3status-rust-0.0.1.drv' failed with exit code 101
error: build of '/nix/store/rzifgpdfmbwsy34vq2sh60lvd949kkzk-i3status-rust-0.0.1.drv' failed on ‘mac1’
error: build of ‘/nix/store/rzifgpdfmbwsy34vq2sh60lvd949kkzk-i3status-rust-0.0.1.drv’ failed

GrahamcOfBorg
GrahamcOfBorg approved these changes Nov 14, 2017
View reviewed changes
Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success for system: x86_64-linux

cp: -r not specified; omitting directory 'target/release/deps'
cp: -r not specified; omitting directory 'target/release/build'
cp: -r not specified; omitting directory 'target/release/.fingerprint'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/wr687fskhnpbs1k12l1yg8ysj56i469h-i3status-rust-0.0.1
shrinking /nix/store/wr687fskhnpbs1k12l1yg8ysj56i469h-i3status-rust-0.0.1/bin/i3status-rs
stripping (with flags -S) in /nix/store/wr687fskhnpbs1k12l1yg8ysj56i469h-i3status-rust-0.0.1/bin 
patching script interpreter paths in /nix/store/wr687fskhnpbs1k12l1yg8ysj56i469h-i3status-rust-0.0.1
checking for references to /tmp/nix-build-i3status-rust-0.0.1.drv-0 in /nix/store/wr687fskhnpbs1k12l1yg8ysj56i469h-i3status-rust-0.0.1...
/nix/store/wr687fskhnpbs1k12l1yg8ysj56i469h-i3status-rust-0.0.1

GrahamcOfBorg
GrahamcOfBorg approved these changes Nov 14, 2017
View reviewed changes
Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success for system: x86_64-linux

/nix/store/wr687fskhnpbs1k12l1yg8ysj56i469h-i3status-rust-0.0.1

@backuitist backuitist force-pushed the i3status branch 2 times, most recently from 5ba90da to 8ace1e3 Compare November 14, 2017 07:20
@backuitist
Copy link
Contributor Author

Changed maintainer to backuitist

@c0bw3b c0bw3b added the 8.has: package (new) This PR adds a new package label Nov 14, 2017
@orivej orivej changed the title i3status-rust: init at 0.0.1 i3status-rust: init at 0.9.0.2017-11-09 Nov 17, 2017
@orivej
Copy link
Contributor

orivej commented Nov 17, 2017

Please review my changes.

  • Upstream has declared version 0.9.0; we are using a more recent commit (and there is no reason not to)
  • dbus_libs were deprecated in favor of dbus
  • the platforms should be linux because it does not build on darwin and is not useful there
  • I've added gperftools to enable tests
  • with rustPlatform for buildRustPackage on the next line is just confusing, I'm going to update the example in the Nixpkgs manual

@backuitist
Copy link
Contributor Author

backuitist commented Nov 17, 2017 via email

@orivej
Copy link
Contributor

orivej commented Nov 17, 2017

Well, they exercise the code and they are fast, I don't see downsides in enabling them.

@backuitist
Copy link
Contributor Author

backuitist commented Nov 17, 2017 via email

@orivej
Copy link
Contributor

orivej commented Nov 17, 2017 •
edited
Loading

gperftools do not become a dependency of the result because nothing in the result references them (the testing binary is not installed). You can confirm this with nix-store -qR /nix/store/*-i3status-rust-0.9.0.2017-11-09.

@orivej orivej merged commit a50e8c8 into NixOS:master Nov 17, 2017
@orivej
Copy link
Contributor

orivej commented Nov 17, 2017

Thank you!

@backuitist backuitist deleted the i3status branch November 17, 2017 11:48
@grahamc grahamc mentioned this pull request Nov 17, 2017
Merged
8 tasks
@orivej
Copy link
Contributor

orivej commented Nov 17, 2017

I've added you to maintainers in d7aefea, just say if you want to change it, or submit a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grahamc grahamc

@tailhook tailhook

@orivej orivej

@GrahamcOfBorg GrahamcOfBorg

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-darwin: 1-10 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@backuitist @grahamc @LnL7 @orivej @tailhook @GrahamcOfBorg @c0bw3b