i3status-rust: init at 0.9.0.2017-11-09 #31626

backuitist · 2017-11-13T20:44:56Z

Motivation for this change

New bar for i3.

Things done

Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- other Linux distributions
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Fits CONTRIBUTING.md.

backuitist · 2017-11-13T20:49:06Z

A few things:

not sure about the maintainer as I don't know that much about Nix
it would be good to be able to add the font-awesome-ttf font to the global fonts, but I have no idea if this is possible?
i've added a version which does not reflect any release (as the application has not been released yet).

grahamc · 2017-11-13T22:16:52Z

pkgs/applications/window-managers/i3/status-rust.nix

+    description = "Very resource-friendly and feature-rich replacement for i3status, written in Rust";
+    homepage = https://github.com/greshake/i3status-rust;
+    license = licenses.gpl3;
+    maintainers = [ maintainers.tailhook ];


Are you volunteering @tailhook as the maintainer? Generally we'd ask you add yourself to the maintainer list (in lib/maintainers.nix) and put your own name here :)

This was probably copied from another package :)

Right this was taken from the manual: https://nixos.org/nixpkgs/manual/#users-guide-to-the-rust-infrastructure
But as I said in my previous comment, I can put my name but I'm not sure I'll be that good of a maintainer ;)
Any idea about the fonts (2nd question)?

grahamc · 2017-11-13T22:17:11Z

@GrahamcOfBorg build i3status-rust

GrahamcOfBorg

Success for system: x86_64-linux

cp: -r not specified; omitting directory 'target/release/deps'
cp: -r not specified; omitting directory 'target/release/build'
cp: -r not specified; omitting directory 'target/release/.fingerprint'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/wr687fskhnpbs1k12l1yg8ysj56i469h-i3status-rust-0.0.1
shrinking /nix/store/wr687fskhnpbs1k12l1yg8ysj56i469h-i3status-rust-0.0.1/bin/i3status-rs
stripping (with flags -S) in /nix/store/wr687fskhnpbs1k12l1yg8ysj56i469h-i3status-rust-0.0.1/bin 
patching script interpreter paths in /nix/store/wr687fskhnpbs1k12l1yg8ysj56i469h-i3status-rust-0.0.1
checking for references to /tmp/nix-build-i3status-rust-0.0.1.drv-0 in /nix/store/wr687fskhnpbs1k12l1yg8ysj56i469h-i3status-rust-0.0.1...
/nix/store/wr687fskhnpbs1k12l1yg8ysj56i469h-i3status-rust-0.0.1

GrahamcOfBorg

Failure for system: x86_64-darwin

  /nix/store/yp374lzwx3wp180yjam44cj4wszl4634-cargo-vendor-0.1.12.drv
  /nix/store/hs4b799i53y0y2l8fnqpavviz6b18asq-i3status-rust-0.0.1-vendor.drv
  /nix/store/29r28vyz48s8aprzzplcq4mi58ql6nbn-i3status-rust-0.0.1.drv
these paths will be fetched (2.84 MiB download, 3.45 MiB unpacked):
  /nix/store/gagdi95vrbl1ddjavlcvr19d430ndc14-dbus-1.10.24-dev
  /nix/store/j6rpjn6m6dpg3x3pn3y1lcrrw6qawf69-cargo-vendor-0.1.12-x86_64-apple-darwin.tar.gz
  /nix/store/l49qg8v2zi5dg6aklqaz518ay6jyw9lw-dbus-1.10.24
  /nix/store/r5j5xdxafbp2ciyx4pmza71mg42gxjrh-dbus-1.10.24-lib
copying path '/nix/store/r5j5xdxafbp2ciyx4pmza71mg42gxjrh-dbus-1.10.24-lib' from 'https://cache.nixos.org'...
error: derivation '/nix/store/sri8wjxxzdz8m0svwvk16xlq5mxhvy68-source.drv' requested impure path '/System/Library/Frameworks/CoreFoundation.framework/CoreFoundation', but it was not in allowed-impure-host-deps

LnL7 · 2017-11-14T00:13:30Z

@GrahamcOfBorg build i3status-rust

GrahamcOfBorg

Failure for system: x86_64-darwin

  /nix/store/sri8wjxxzdz8m0svwvk16xlq5mxhvy68-source.drv
  /nix/store/yp374lzwx3wp180yjam44cj4wszl4634-cargo-vendor-0.1.12.drv
  /nix/store/hs4b799i53y0y2l8fnqpavviz6b18asq-i3status-rust-0.0.1-vendor.drv
  /nix/store/29r28vyz48s8aprzzplcq4mi58ql6nbn-i3status-rust-0.0.1.drv
these paths will be fetched (2.73 MiB download, 3.13 MiB unpacked):
  /nix/store/gagdi95vrbl1ddjavlcvr19d430ndc14-dbus-1.10.24-dev
  /nix/store/j6rpjn6m6dpg3x3pn3y1lcrrw6qawf69-cargo-vendor-0.1.12-x86_64-apple-darwin.tar.gz
  /nix/store/l49qg8v2zi5dg6aklqaz518ay6jyw9lw-dbus-1.10.24
copying path '/nix/store/l49qg8v2zi5dg6aklqaz518ay6jyw9lw-dbus-1.10.24' from 'https://cache.nixos.org'...
error: a 'x86_64-darwin' is required to build '/nix/store/sri8wjxxzdz8m0svwvk16xlq5mxhvy68-source.drv', but I am a 'x86_64-linux'

LnL7 · 2017-11-14T00:15:49Z

@GrahamcOfBorg build i3status-rust

GrahamcOfBorg

Failure for system: x86_64-darwin



error: aborting due to previous error

error: Could not compile `i3status-rs`.

To learn more, run the command again with --verbose.
builder for '/nix/store/rzifgpdfmbwsy34vq2sh60lvd949kkzk-i3status-rust-0.0.1.drv' failed with exit code 101
error: build of '/nix/store/rzifgpdfmbwsy34vq2sh60lvd949kkzk-i3status-rust-0.0.1.drv' failed on ‘mac1’
error: build of ‘/nix/store/rzifgpdfmbwsy34vq2sh60lvd949kkzk-i3status-rust-0.0.1.drv’ failed

GrahamcOfBorg

Success for system: x86_64-linux

cp: -r not specified; omitting directory 'target/release/deps'
cp: -r not specified; omitting directory 'target/release/build'
cp: -r not specified; omitting directory 'target/release/.fingerprint'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/wr687fskhnpbs1k12l1yg8ysj56i469h-i3status-rust-0.0.1
shrinking /nix/store/wr687fskhnpbs1k12l1yg8ysj56i469h-i3status-rust-0.0.1/bin/i3status-rs
stripping (with flags -S) in /nix/store/wr687fskhnpbs1k12l1yg8ysj56i469h-i3status-rust-0.0.1/bin 
patching script interpreter paths in /nix/store/wr687fskhnpbs1k12l1yg8ysj56i469h-i3status-rust-0.0.1
checking for references to /tmp/nix-build-i3status-rust-0.0.1.drv-0 in /nix/store/wr687fskhnpbs1k12l1yg8ysj56i469h-i3status-rust-0.0.1...
/nix/store/wr687fskhnpbs1k12l1yg8ysj56i469h-i3status-rust-0.0.1

GrahamcOfBorg

Success for system: x86_64-linux

/nix/store/wr687fskhnpbs1k12l1yg8ysj56i469h-i3status-rust-0.0.1

backuitist · 2017-11-14T07:21:10Z

Changed maintainer to backuitist

orivej · 2017-11-17T02:02:28Z

Please review my changes.

Upstream has declared version 0.9.0; we are using a more recent commit (and there is no reason not to)
dbus_libs were deprecated in favor of dbus
the platforms should be linux because it does not build on darwin and is not useful there
I've added gperftools to enable tests
with rustPlatform for buildRustPackage on the next line is just confusing, I'm going to update the example in the Nixpkgs manual

backuitist · 2017-11-17T08:21:58Z

Hey, thanks for that! One thing about the test, I didn't enable them because I don't think they are automated. Especially the performance one. It says in the code "Now profiling the {0} block by executing {1} updates.\n Use pprof to analyze {0}.profile"

…

On Nov 17, 2017 03:03, "Orivej Desh" ***@***.***> wrote: ***@***.**** approved this pull request. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#31626 (review)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AA-GweGdUlyUd8--vwVGu80D2DItEqh_ks5s3OmDgaJpZM4QcYlf> .

orivej · 2017-11-17T08:24:52Z

Well, they exercise the code and they are fast, I don't see downsides in enabling them.

backuitist · 2017-11-17T08:44:00Z

The downsides are a dependency on gperftool and time spent running them, but you're right they do exercise the code. I'm new to nixos, so is gperftool a build/test dependency, or will be be transitively fetched by users when they install i3status-rust?

…

On Nov 17, 2017 09:24, "Orivej Desh" ***@***.***> wrote: Well, they exercise the code and they are fast, I don't see downsides in enabling them. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#31626 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AA-GweOxSlwF_8Z1H1bxVRc0AgUKgoALks5s3ULYgaJpZM4QcYlf> .

orivej · 2017-11-17T08:57:32Z

gperftools do not become a dependency of the result because nothing in the result references them (the testing binary is not installed). You can confirm this with nix-store -qR /nix/store/*-i3status-rust-0.9.0.2017-11-09.

orivej · 2017-11-17T10:45:19Z

Thank you!

orivej · 2017-11-17T12:25:24Z

I've added you to maintainers in d7aefea, just say if you want to change it, or submit a PR.

GrahamcOfBorg added 10.rebuild-darwin: 0 10.rebuild-linux: 0 labels Nov 13, 2017

grahamc reviewed Nov 13, 2017

View reviewed changes

GrahamcOfBorg approved these changes Nov 13, 2017

View reviewed changes

GrahamcOfBorg reviewed Nov 13, 2017

View reviewed changes

GrahamcOfBorg reviewed Nov 14, 2017

View reviewed changes

GrahamcOfBorg approved these changes Nov 14, 2017

View reviewed changes

backuitist force-pushed the i3status branch 2 times, most recently from 5ba90da to 8ace1e3 Compare November 14, 2017 07:20

GrahamcOfBorg added 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Nov 14, 2017

c0bw3b added the 8.has: package (new) label Nov 14, 2017

orivej force-pushed the i3status branch from 8ace1e3 to fb64c5e Compare November 17, 2017 01:43

orivej changed the title ~~i3status-rust: init at 0.0.1~~ i3status-rust: init at 0.9.0.2017-11-09 Nov 17, 2017

orivej force-pushed the i3status branch from fb64c5e to 327b239 Compare November 17, 2017 01:45

i3status-rust: init at 0.9.0.2017-11-09

898090f

orivej force-pushed the i3status branch from 327b239 to 898090f Compare November 17, 2017 01:47

orivej approved these changes Nov 17, 2017

View reviewed changes

orivej merged commit a50e8c8 into NixOS:master Nov 17, 2017

backuitist deleted the i3status branch November 17, 2017 11:48

grahamc mentioned this pull request Nov 17, 2017

vagrant: 2.0.0 -> 2.0.1 (fixes vagrant with virtualbox 5.2) #31768

Merged

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

i3status-rust: init at 0.9.0.2017-11-09 #31626

i3status-rust: init at 0.9.0.2017-11-09 #31626

backuitist commented Nov 13, 2017 •

edited

backuitist commented Nov 13, 2017 •

edited

grahamc Nov 13, 2017

tailhook Nov 13, 2017

backuitist Nov 14, 2017

grahamc commented Nov 13, 2017 •

edited by LnL7

GrahamcOfBorg left a comment

GrahamcOfBorg left a comment

LnL7 commented Nov 14, 2017

GrahamcOfBorg left a comment

LnL7 commented Nov 14, 2017

GrahamcOfBorg left a comment

GrahamcOfBorg left a comment

GrahamcOfBorg left a comment

backuitist commented Nov 14, 2017

orivej commented Nov 17, 2017

backuitist commented Nov 17, 2017 via email

orivej commented Nov 17, 2017

backuitist commented Nov 17, 2017 via email

orivej commented Nov 17, 2017 •

edited

orivej commented Nov 17, 2017

orivej commented Nov 17, 2017

i3status-rust: init at 0.9.0.2017-11-09 #31626

i3status-rust: init at 0.9.0.2017-11-09 #31626

Conversation

backuitist commented Nov 13, 2017 • edited

Motivation for this change

Things done

backuitist commented Nov 13, 2017 • edited

grahamc Nov 13, 2017

Choose a reason for hiding this comment

tailhook Nov 13, 2017

Choose a reason for hiding this comment

backuitist Nov 14, 2017

Choose a reason for hiding this comment

grahamc commented Nov 13, 2017 • edited by LnL7

GrahamcOfBorg left a comment

Choose a reason for hiding this comment

GrahamcOfBorg left a comment

Choose a reason for hiding this comment

LnL7 commented Nov 14, 2017

GrahamcOfBorg left a comment

Choose a reason for hiding this comment

LnL7 commented Nov 14, 2017

GrahamcOfBorg left a comment

Choose a reason for hiding this comment

GrahamcOfBorg left a comment

Choose a reason for hiding this comment

GrahamcOfBorg left a comment

Choose a reason for hiding this comment

backuitist commented Nov 14, 2017

orivej commented Nov 17, 2017

backuitist commented Nov 17, 2017 via email

orivej commented Nov 17, 2017

backuitist commented Nov 17, 2017 via email

orivej commented Nov 17, 2017 • edited

orivej commented Nov 17, 2017

orivej commented Nov 17, 2017

backuitist commented Nov 13, 2017 •

edited

backuitist commented Nov 13, 2017 •

edited

grahamc commented Nov 13, 2017 •

edited by LnL7

orivej commented Nov 17, 2017 •

edited