Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bitcoin: 0.15.0.1 -> 0.15.1 #31625

Merged
merged 1 commit into from Nov 14, 2017
Merged

bitcoin: 0.15.0.1 -> 0.15.1 #31625

merged 1 commit into from Nov 14, 2017

Conversation

roconnor
Copy link
Contributor

I have also updated the dependencies for bitcoin:

  • qt4 is updated to qt5
  • miniupnpc 1 is updated to miniupnpc 2
  • zeromq dependency has been added to enable ZeroMQ support.
Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@roconnor
bitcoin: 0.15.0.1 -> 0.15.1
4173e86 
I have also updated the dependencies for bitcoin:

* qt4 is updated to qt5
* miniupnpc 1 is updated to miniupnpc 2
* zeromq dependency has been added to enable ZeroMQ support.
@fpletz
Copy link
Member

fpletz commented Nov 14, 2017

@GrahamcOfBorg build bitcoin

GrahamcOfBorg
GrahamcOfBorg reviewed Nov 14, 2017
View reviewed changes
Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failure for system: x86_64-darwin

checking for main in -lminiupnpc... (cached) yes
checking miniupnpc/upnperrors.h usability... yes
checking miniupnpc/upnperrors.h presence... yes
checking for miniupnpc/upnperrors.h... yes
checking for main in -lminiupnpc... (cached) yes
checking for Qt5Core Qt5Gui Qt5Network Qt5Widgets... no
configure: error: Qt dependencies not found
builder for '/nix/store/xlnjagpb3f9xrslyb30kainyrkzgrhrh-bitcoin-0.15.1.drv' failed with exit code 1
error: build of '/nix/store/xlnjagpb3f9xrslyb30kainyrkzgrhrh-bitcoin-0.15.1.drv' failed on ‘mac1’
error: build of ‘/nix/store/xlnjagpb3f9xrslyb30kainyrkzgrhrh-bitcoin-0.15.1.drv’ failed

@fpletz
Copy link
Member

fpletz commented Nov 14, 2017

The Darwin build error can be ignore because it has been broken for a while: https://hydra.nixos.org/job/nixpkgs/trunk/altcoins.bitcoin.x86_64-darwin/all

@fpletz
Copy link
Member

fpletz commented Nov 14, 2017

@GrahamcOfBorg build bitcoind

GrahamcOfBorg
GrahamcOfBorg reviewed Nov 14, 2017
View reviewed changes
Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failure for system: x86_64-darwin

error: attribute ‘bitcoind’ in selection path ‘bitcoind’ not found

@fpletz
Copy link
Member

fpletz commented Nov 14, 2017

@GrahamcOfBorg build altcoins.bitcoind

GrahamcOfBorg
GrahamcOfBorg reviewed Nov 14, 2017
View reviewed changes
Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failure for system: x86_64-darwin

checking whether the Boost::Program_Options library is available... yes
checking for exit in -lboost_program_options... yes
checking whether the Boost::Thread library is available... yes
checking for exit in -lboost_thread... yes
checking whether the Boost::Chrono library is available... yes
checking for exit in -lboost_chrono... yes
configure: error: hexdump is required for tests
builder for '/nix/store/ff6l013vym6z40jvzdj3bnx5z6xwgihr-bitcoind-0.15.1.drv' failed with exit code 1
error: build of '/nix/store/ff6l013vym6z40jvzdj3bnx5z6xwgihr-bitcoind-0.15.1.drv' failed on ‘mac1’
error: build of ‘/nix/store/ff6l013vym6z40jvzdj3bnx5z6xwgihr-bitcoind-0.15.1.drv’ failed

GrahamcOfBorg
GrahamcOfBorg approved these changes Nov 14, 2017
View reviewed changes
Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success for system: x86_64-linux

shrinking /nix/store/fn6pi1n55gkzc795ciqf2ffn1dhsjz21-bitcoin-0.15.1/bin/bitcoin-cli
shrinking /nix/store/fn6pi1n55gkzc795ciqf2ffn1dhsjz21-bitcoin-0.15.1/bin/bitcoind
shrinking /nix/store/fn6pi1n55gkzc795ciqf2ffn1dhsjz21-bitcoin-0.15.1/lib/libbitcoinconsensus.so.0.0.0
gzipping man pages under /nix/store/fn6pi1n55gkzc795ciqf2ffn1dhsjz21-bitcoin-0.15.1/share/man/
stripping (with flags -S) in /nix/store/fn6pi1n55gkzc795ciqf2ffn1dhsjz21-bitcoin-0.15.1/lib  /nix/store/fn6pi1n55gkzc795ciqf2ffn1dhsjz21-bitcoin-0.15.1/bin 
patching script interpreter paths in /nix/store/fn6pi1n55gkzc795ciqf2ffn1dhsjz21-bitcoin-0.15.1
checking for references to /tmp/nix-build-bitcoin-0.15.1.drv-0 in /nix/store/fn6pi1n55gkzc795ciqf2ffn1dhsjz21-bitcoin-0.15.1...
postPatchMkspecs
postMoveQtStaticLibs
/nix/store/fn6pi1n55gkzc795ciqf2ffn1dhsjz21-bitcoin-0.15.1

GrahamcOfBorg
GrahamcOfBorg reviewed Nov 14, 2017
View reviewed changes
Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failure for system: x86_64-linux

error: attribute ‘bitcoind’ in selection path ‘bitcoind’ not found

GrahamcOfBorg
GrahamcOfBorg approved these changes Nov 14, 2017
View reviewed changes
Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success for system: x86_64-linux

shrinking /nix/store/6fydfrff867iabrg8ix1asjr00kvmpjd-bitcoind-0.15.1/bin/bench_bitcoin
shrinking /nix/store/6fydfrff867iabrg8ix1asjr00kvmpjd-bitcoind-0.15.1/bin/test_bitcoin
shrinking /nix/store/6fydfrff867iabrg8ix1asjr00kvmpjd-bitcoind-0.15.1/bin/bitcoin-cli
shrinking /nix/store/6fydfrff867iabrg8ix1asjr00kvmpjd-bitcoind-0.15.1/bin/bitcoind
shrinking /nix/store/6fydfrff867iabrg8ix1asjr00kvmpjd-bitcoind-0.15.1/lib/libbitcoinconsensus.so.0.0.0
gzipping man pages under /nix/store/6fydfrff867iabrg8ix1asjr00kvmpjd-bitcoind-0.15.1/share/man/
stripping (with flags -S) in /nix/store/6fydfrff867iabrg8ix1asjr00kvmpjd-bitcoind-0.15.1/lib  /nix/store/6fydfrff867iabrg8ix1asjr00kvmpjd-bitcoind-0.15.1/bin 
patching script interpreter paths in /nix/store/6fydfrff867iabrg8ix1asjr00kvmpjd-bitcoind-0.15.1
checking for references to /tmp/nix-build-bitcoind-0.15.1.drv-0 in /nix/store/6fydfrff867iabrg8ix1asjr00kvmpjd-bitcoind-0.15.1...
/nix/store/6fydfrff867iabrg8ix1asjr00kvmpjd-bitcoind-0.15.1

@roconnor
Copy link
Contributor Author

roconnor commented Nov 14, 2017 •
edited

FWIW, hexdump is provided by untillinux on stdenv.isLinux. I don't have a MacOSX system to test on, but I'm guessing it hasn't been building for a while.

Edit: yes it has been broken for a long time: https://hydra.nixos.org/job/nixpkgs/trunk/altcoins.bitcoind.x86_64-darwin/all

@fpletz
Copy link
Member

fpletz commented Nov 14, 2017 •
edited

This should be in bsdmainutils (not in nixpkgs, Debian this for instance), that should also be provided in Darwin by default.

Homebrew doesn't have a special dependendy: https://github.com/Homebrew/homebrew-core/blob/f1a3fd6bd5263d69155a6518b7dcfc50c38af913/Formula/bitcoin.rb

Not sure which derivation that would bein nixpkgs, though.

@fpletz fpletz merged commit 33b7ff9 into NixOS:master Nov 14, 2017
@roconnor roconnor deleted the bitcoin branch November 14, 2017 17:27
@jb55
Copy link
Contributor

jb55 commented Dec 27, 2017

@roconnor do you have something cooking for bitcoin master? I noticed issues with boost_system during the configure phase 🤔

@jb55
Copy link
Contributor

jb55 commented Dec 27, 2017

oh nevermind, I think I was missing a configure flag when building locally...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jb55 jb55 jb55 approved these changes

@fpletz fpletz fpletz approved these changes

@GrahamcOfBorg GrahamcOfBorg GrahamcOfBorg approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@roconnor @fpletz @jb55 @GrahamcOfBorg