Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go: 1.9.1 -> 1.9.2 && Go: 1.8.4 -> 1.8.5 #30820

Merged
merged 2 commits into from Oct 26, 2017
Merged

Conversation

adisbladis
Copy link
Member

Motivation for this change

Golang bugfix releases

Needs backport to 17.09

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@NeQuissimus
Copy link
Member

@GrahamcOfBorg go

@NeQuissimus
Copy link
Member

@grahamc I guess I am not allowed to use your Borg alter ego? :D

@NeQuissimus NeQuissimus merged commit a1f7aa1 into NixOS:master Oct 26, 2017
@NeQuissimus
Copy link
Member

Both built for me, porting

@NeQuissimus
Copy link
Member

2178321 and cd9ce6d

@adisbladis
Copy link
Member Author

@NeQuissimus Thanks :)

@grahamc
Copy link
Member

grahamc commented Oct 26, 2017 via email

@NeQuissimus
Copy link
Member

@grahamc You should change your profile pic to the Borg Queen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants