Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

git-hub: 0.11.1 -> 1.0.0 #30821

Closed
wants to merge 1 commit into from
Closed

git-hub: 0.11.1 -> 1.0.0 #30821

wants to merge 1 commit into from

Conversation

rycee
Copy link
Member

@rycee rycee commented Oct 26, 2017

Motivation for this change

To update the git-hub package.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@rycee rycee requested a review from nckx October 26, 2017 10:32
nckx
nckx approved these changes Oct 26, 2017
View reviewed changes
Copy link
Member

@nckx nckx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rycee
Copy link
Member Author

rycee commented Oct 26, 2017

Thanks! I've merged to master.

@rycee rycee closed this Oct 26, 2017
@rycee rycee deleted the bump/git-hub branch October 26, 2017 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nckx nckx nckx approved these changes

Assignees
No one assigned
Labels
8.has: package (update)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rycee @nckx