Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IntensityCurve not working? #243

Closed
OhioBob opened this issue Oct 22, 2017 · 8 comments
Closed

IntensityCurve not working? #243

OhioBob opened this issue Oct 22, 2017 · 8 comments

Comments

@OhioBob
Copy link

OhioBob commented Oct 22, 2017

I don't think IntensityCurve is working as intended, or at least not as I understand it. I recently tried an experiment in which I used different values for IntensityCurve and ScaledIntensityCurve, in the hope that I could create different lighting conditions in map/tracking station mode versus flight mode. What I found is that the lighting in all modes is currently being controlled by ScaledIntensityCurve. From what I could determine, IntensityCurve currently doesn't do anything.

@Sigma88
Copy link
Contributor

Sigma88 commented Oct 23, 2017

I can confirm this issue but I can't really add anything to the discussion other than, this is not working :|

@StollD
Copy link
Member

StollD commented Oct 26, 2017

So this is funny.

KSP has never used two intensities. It has two seperate lights, but the intensity of the scaled space light is assigned to the local space light every frame. Back when I wrote Kopernicus star code, I copied the behaviour from KSP's original code, but I didn't notice this. That means, the local space intensity from the config, even when it still was a single number, got never used. Oh well.

Anyway, I fixed this, and the IVAIntensityCurve with bdfc343

@Sigma88
Copy link
Contributor

Sigma88 commented Oct 26, 2017

I have also noticed that the IVA color doesn't seem to affect the IVA of vessels

both the small preview in the lower right and the IVA view (default hotkey = [C]) always have white light

@OhioBob
Copy link
Author

OhioBob commented Oct 26, 2017

Thanks for the response. So with this fix you've made, will IntensityCurve actually work now? Also, what are the distance units in IntensityCurve and IVAIntensityCurve? I know that ScaledIntensityCurve uses km/6000, but I've heard IntensityCurve might be just kilometers, and I don't know anything about IVAIntensityCurve. Can you verify the correct units?

@StollD
Copy link
Member

StollD commented Oct 26, 2017

It will work and use kilometers

@OhioBob
Copy link
Author

OhioBob commented Oct 26, 2017

Thanks. Are the IVA units kilometers also?

@StollD
Copy link
Member

StollD commented Oct 26, 2017

Yes

@OhioBob
Copy link
Author

OhioBob commented Oct 26, 2017

Oops, I just realized I made a mistake. ScaledIntensityCurve uses meters/6000, or km/6. I think IntensityCurve and IVAIntensityCurve are suppose to use meters, not kilometers. Is that right?

@StollD StollD closed this as completed Nov 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants