Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

borgbackup: fix ssh binary location #30897

Merged
merged 2 commits into from Oct 29, 2017
Merged

borgbackup: fix ssh binary location #30897

merged 2 commits into from Oct 29, 2017

Conversation

flokli
Copy link
Contributor

@flokli flokli commented Oct 28, 2017

Motivation for this change

When executing borg somewhere without ssh in $PATH (like in a systemd user session), borg is not able to find the ssh binary.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@flokli flokli force-pushed the borgbackup-ssh branch 2 times, most recently from af079a9 to fc65c30 Compare October 28, 2017 15:37
@joachifm joachifm requested a review from nckx October 28, 2017 18:46
@grahamc
Copy link
Member

grahamc commented Oct 28, 2017

@GrahamcOfBorg borgbackup

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shrinking /nix/store/qcl2i97zhp3ip54yjb1y0cv71fgas4iz-borgbackup-1.1.1/lib/python3.6/site-packages/borg/item.cpython-36m-x86_64-linux-gnu.so
shrinking /nix/store/qcl2i97zhp3ip54yjb1y0cv71fgas4iz-borgbackup-1.1.1/lib/python3.6/site-packages/borg/platform/linux.cpython-36m-x86_64-linux-gnu.so
shrinking /nix/store/qcl2i97zhp3ip54yjb1y0cv71fgas4iz-borgbackup-1.1.1/lib/python3.6/site-packages/borg/platform/posix.cpython-36m-x86_64-linux-gnu.so
gzipping man pages under /nix/store/qcl2i97zhp3ip54yjb1y0cv71fgas4iz-borgbackup-1.1.1/share/man/
stripping (with flags -S) in /nix/store/qcl2i97zhp3ip54yjb1y0cv71fgas4iz-borgbackup-1.1.1/lib  /nix/store/qcl2i97zhp3ip54yjb1y0cv71fgas4iz-borgbackup-1.1.1/bin
patching script interpreter paths in /nix/store/qcl2i97zhp3ip54yjb1y0cv71fgas4iz-borgbackup-1.1.1
checking for references to /tmp/nix-build-borgbackup-1.1.1.drv-0 in /nix/store/qcl2i97zhp3ip54yjb1y0cv71fgas4iz-borgbackup-1.1.1...
wrapping `/nix/store/qcl2i97zhp3ip54yjb1y0cv71fgas4iz-borgbackup-1.1.1/bin/borgfs'...
wrapping `/nix/store/qcl2i97zhp3ip54yjb1y0cv71fgas4iz-borgbackup-1.1.1/bin/borg'...
/nix/store/qcl2i97zhp3ip54yjb1y0cv71fgas4iz-borgbackup-1.1.1

@FRidh FRidh merged commit bd70749 into NixOS:master Oct 29, 2017
@flokli flokli deleted the borgbackup-ssh branch October 29, 2017 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants