Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chez: 9.4 -> 9.5 #30914

Merged
merged 1 commit into from Oct 29, 2017
Merged

chez: 9.4 -> 9.5 #30914

merged 1 commit into from Oct 29, 2017

Conversation

tilpner
Copy link
Member

@tilpner tilpner commented Oct 29, 2017

Motivation for this change

Package update to 9.5

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@tilpner
Copy link
Member Author

tilpner commented Oct 29, 2017

@thoughtpolice Should this run Chez' tests? The BUILDING file says it'll take about 30 minutes.

@grahamc
Copy link
Member

grahamc commented Oct 29, 2017

@GrahamcOfBorg chez

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/achbvjgikvrd5h4h8c3n1sdd1j9v1jc1-chez-scheme-9.5-20171012
shrinking /nix/store/achbvjgikvrd5h4h8c3n1sdd1j9v1jc1-chez-scheme-9.5-20171012/bin/scheme-script
shrinking /nix/store/achbvjgikvrd5h4h8c3n1sdd1j9v1jc1-chez-scheme-9.5-20171012/bin/scheme
shrinking /nix/store/achbvjgikvrd5h4h8c3n1sdd1j9v1jc1-chez-scheme-9.5-20171012/bin/petite
gzipping man pages under /nix/store/achbvjgikvrd5h4h8c3n1sdd1j9v1jc1-chez-scheme-9.5-20171012/share/man/
stripping (with flags -S) in /nix/store/achbvjgikvrd5h4h8c3n1sdd1j9v1jc1-chez-scheme-9.5-20171012/lib  /nix/store/achbvjgikvrd5h4h8c3n1sdd1j9v1jc1-chez-scheme-9.5-20171012/bin
patching script interpreter paths in /nix/store/achbvjgikvrd5h4h8c3n1sdd1j9v1jc1-chez-scheme-9.5-20171012
checking for references to /tmp/nix-build-chez-scheme-9.5-20171012.drv-0 in /nix/store/achbvjgikvrd5h4h8c3n1sdd1j9v1jc1-chez-scheme-9.5-20171012...
/nix/store/achbvjgikvrd5h4h8c3n1sdd1j9v1jc1-chez-scheme-9.5-20171012

@thoughtpolice
Copy link
Member

Yes, not running the tests was an oversight. If you could do that, that'd be great!

Copy link
Member

@thoughtpolice thoughtpolice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Requesting changes just to make sure it goes back into review state for test changes; otherwise LGTM!)

Copy link
Member

@thoughtpolice thoughtpolice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per a discussion on IRC with @tilpner, the tests take a rather unreasonably long amount of time to run (1hr+), so for now we'll just go with this as-is and open an issue for later.

@thoughtpolice thoughtpolice merged commit 14291c2 into NixOS:master Oct 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants