Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ungoogled-chromium: init at 58.0.3029.110-1 #30916

Closed
wants to merge 1 commit into from
Closed

ungoogled-chromium: init at 58.0.3029.110-1 #30916

wants to merge 1 commit into from

Conversation

ylwghst
Copy link
Contributor

@ylwghst ylwghst commented Oct 29, 2017 •
edited by 7c6f434c

Motivation for this change

This Chromium contains very interesting patches improving privacy, removing Google integrations and services brought by https://github.com/Eloston/ungoogled-chromium

ungoogled-chromium is a set of configuration flags, patches, and custom scripts. These components altogether strive to accomplish the following:

  • Disable or remove offending services and features that communicate with Google or weaken privacy
  • Strip binaries from the source tree, and use those provided by the system or build them from source
  • Add, modify, or disable features that inhibit control and transparency (these changes are minor and
    do not have significant impacts on the general user experience)

I slightly modified nix declarations from generic chromium package available in master to be able to get and build the older release of chromium source code used by ungoogled-chromium project together with ungoogled-chromium patches.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@FRidh
Copy link
Member

FRidh commented Oct 29, 2017

Patches should be fetched when possible.

@ylwghst
Copy link
Contributor Author

ylwghst commented Oct 29, 2017 •
edited

@volth patches are exactly same
@FRidh ok

I'll try improve it to fetch all patches ASAP.

@bendlas
Copy link
Contributor

bendlas commented Jan 21, 2018 •
edited

Please try to minimize copy-pasting, by either
a) modifying the regular chromium package, to accept an enableUngoogled flag, or
b) creating a separate package, by using overrideDerivation on regular chromium

if you copy-paste the whole chromium derivation as a starting point, please do so in a separate commit, so that changes can be picked out later.

matthewbauer
matthewbauer requested changes Apr 21, 2018
View reviewed changes
Copy link
Member

@matthewbauer matthewbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See @bendlas comments

@Chiiruno
Copy link
Contributor

Chiiruno commented Sep 4, 2018

Still working on this?

@rht rht mentioned this pull request Nov 30, 2018
Closed
13 tasks
@c0bw3b
Copy link
Contributor

c0bw3b commented May 18, 2019

Stalled

@c0bw3b c0bw3b closed this May 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewbauer matthewbauer matthewbauer requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@ylwghst @FRidh @bendlas @Chiiruno @c0bw3b @matthewbauer