install documentation: document boot.loader.grub.useOSProber #30911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FRidh
reviewed
Oct 29, 2017
| @@ -140,6 +140,11 @@ | |||
| the GRUB boot loader is to be installed. Without it, NixOS cannot | |||
| boot.</para> | |||
|
|
|||
| <para>If you have other operating systems running on your machine before | |||
There was a problem hiding this comment.
Good idea. Do try to write without using you.
Consider enabling the
boot.loader.grub.useOSProberoption to automatically add existing operating systems to the GRUB menu.
disassembler
force-pushed
the
nixos-grub-os-probe-docs
branch
from
370feb7
to
8a77a30
Compare
|
@FRidh I completely agree. I originally followed the tense used in the previous paragraph. How's this version look? |
|
Excellent, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
addresses #30876
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)