tbb: clang support #30918
tbb: clang support #30918
Conversation
Added compiler and stdver parameters, to support non-gcc compilers, and enable perfect exception forwarding (std::exception_ptr) on platforms where C++11 is not enabled by default
| @@ -11,6 +11,11 @@ stdenv.mkDerivation rec { | |||
| sha256 = "1lygz07va6hsv2vlx9zwz5d2n81rxsdhmh0pqxgj8n1bvb1rp0qw"; | |||
| }; | |||
|
|
|||
| makeFlags = concatStringsSep " " ( | |||
| optional (compiler != null) "compiler=${compiler}" ++ | |||
There was a problem hiding this comment.
How is that used by the build? If it's just for the binary $CC or cc can be used.
There was a problem hiding this comment.
This is used to select a makefile (which then determines the binary). It needs to have a specific name in ["gcc", "clang", "icc", "suncc", etc]. I'm not sure how to do this with $CC or cc as you suggested.
There was a problem hiding this comment.
was just wondering if we could get rid of the conditional, it seems to work fine on darwin at the moment tho (that uses clang by default)
There was a problem hiding this comment.
It works fine on darwin because the macos makefile sets the compiler to clang by default:
https://github.com/01org/tbb/blob/2018_U1/build/macos.inc#L60
whereas on linux the compilier is set to gcc by default:
https://github.com/01org/tbb/blob/2018_U1/build/linux.inc#L71
Added compiler and stdver parameters, to support non-gcc compilers, and enable
perfect exception forwarding (std::exception_ptr) on platforms where C++11 is not enabled by default
Motivation for this change
Add support for compiling tbb with clang. Support building tbb with std::exception_ptr enabled on platforms that don't support it by default.
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)