treewide: use https addresses where possible #30906

iblech · 2017-10-28T20:33:54Z

Motivation for this change

In my social circle, it's considered slightly inpolite to use http instead of https addresses. :-) Therefore I thought to give rewriting of all http addresses in the nixpkgs repository a go, just as an experiment.

Of the approximately 13000 http links contained in this repository, 5000 could be rewritten as https links, 3000 couldn't be upgraded, and 4000 were 404's. The numbers are not very precise, since I didn't bother to accurately filter local and example addresses, and also because at one point during the test my internet connection was flaky.

If you want to study the diff, then I recommend using git diff -U0 to only show changed lines. The context, which is usually quite helpful, is here distracting.

This pull request isn't primarily meant to be merged. In particular, I didn't rebuild all of NixOS to check for breakage. :-) Rather, I just wanted to raise awareness of this issue. (I'm not trying to start a religious war and don't particularly care. Of course the issue is not really an issue for NixOS since we verify sha256sums. Still we could gain street creds if we could proclaim that "NixOS doesn't contain a single http link".)

Things done

Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- other Linux distributions
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Fits CONTRIBUTING.md.

iblech · 2017-10-28T22:24:07Z

For anyone wondering, the Travis build fails with "argument list too long" because the number of files touched by this commit is too large. This is probably a good thing.

grahamc

I reviewed some. how did you test it? A script?

grahamc · 2017-10-29T07:05:23Z

doc/coding-conventions.xml

@@ -670,7 +670,7 @@ src = fetchFromGitHub {
 patches = [
  (fetchpatch {
    name = "fix-check-for-using-shared-freetype-lib.patch";
-    url = "http://git.ghostscript.com/?p=ghostpdl.git;a=patch;h=8f5d285";
+    url = "https://git.ghostscript.com/?p=ghostpdl.git;a=patch;h=8f5d285";


grahamc · 2017-10-29T07:05:34Z

doc/introduction.md

@@ -7,26 +7,26 @@ date: 2015-11-25
 # Introduction

 The Nix Packages collection (Nixpkgs) is a set of thousands of packages for the
-[Nix package manager](http://nixos.org/nix/), released under a
+[Nix package manager](https://nixos.org/nix/), released under a


grahamc · 2017-10-29T07:05:42Z

doc/introduction.md

 [permissive MIT/X11 license](https://github.com/NixOS/nixpkgs/blob/master/COPYING).
 Packages are available for several platforms, and can be used with the Nix
 package manager on most GNU/Linux distributions as well as NixOS.

 This manual primarily describes how to write packages for the Nix Packages collection
 (Nixpkgs). Thus it’s mainly for packagers and developers who want to add packages to
 Nixpkgs. If you like to learn more about the Nix package manager and the Nix
-expression language, then you are kindly referred to the [Nix manual](http://nixos.org/nix/manual/).
+expression language, then you are kindly referred to the [Nix manual](https://nixos.org/nix/manual/).


grahamc · 2017-10-29T07:05:50Z

doc/introduction.md


 ## Overview of Nixpkgs

 Nix expressions describe how to build packages from source and are collected in
 the [nixpkgs repository](https://github.com/NixOS/nixpkgs). Also included in the
 collection are Nix expressions for
-[NixOS modules](http://nixos.org/nixos/manual/index.html#sec-writing-modules).
+[NixOS modules](https://nixos.org/nixos/manual/index.html#sec-writing-modules).


grahamc · 2017-10-29T07:05:58Z

doc/introduction.md

 With these expressions the Nix package manager can build binary packages.

 Packages, including the Nix packages collection, are distributed through
-[channels](http://nixos.org/nix/manual/#sec-channels). The collection is
+[channels](https://nixos.org/nix/manual/#sec-channels). The collection is


grahamc · 2017-10-29T07:07:55Z

doc/languages-frameworks/haskell.md

 It has first-class support for Nix. Stack can optionally use Nix to
 automatically select the right version of GHC and other build tools to build,
 test and execute apps in an existing project downloaded from somewhere on the
 Internet. Pass the `--nix` flag to any `stack` command to do so, e.g.
 ```shell
-git clone --recursive http://github.com/yesodweb/wai
+git clone --recursive https://github.com/yesodweb/wai


grahamc · 2017-10-29T07:08:30Z

doc/languages-frameworks/haskell.md

@@ -890,7 +890,7 @@ failures. Additionally the source of your package is gotten from first invoking
 #### checkUnusedPackages

 Applying `haskell.lib.checkUnusedPackages` to a Haskell package invokes
-the [packunused](http://hackage.haskell.org/package/packunused) tool on the
+the [packunused](https://hackage.haskell.org/package/packunused) tool on the


this file looks good

grahamc · 2017-10-29T07:09:45Z

doc/languages-frameworks/python.md

@@ -563,7 +563,7 @@ The following is an example:
    propagatedBuildInputs = [ self.ZopeInterface ];

    meta = {
-      homepage = http://twistedmatrix.com/;
+      homepage = https://twistedmatrix.com/;
      description = "Twisted, an event-driven networking engine written in Python";
      license = stdenv.lib.licenses.mit;
    };


This file looks good.

grahamc · 2017-10-29T07:10:04Z

doc/languages-frameworks/ruby.xml

@@ -34,7 +34,7 @@ bundlerEnv rec {

  meta = with lib; {
    description = "A monitoring framework that aims to be simple, malleable, and scalable";
-    homepage    = http://sensuapp.org/;
+    homepage    = https://sensuapp.org/;
    license     = with licenses; mit;
    maintainers = with maintainers; [ theuni ];
    platforms   = platforms.unix;


grahamc · 2017-10-29T07:11:05Z

doc/meta.xml

  </varlistentry>

  <varlistentry>
    <term><varname>downloadPage</varname></term>
    <listitem><para>The page where a link to the current version can be found.  Example:
-    <literal>http://ftp.gnu.org/gnu/hello/</literal></para></listitem>
+    <literal>https://ftp.gnu.org/gnu/hello/</literal></para></listitem>
  </varlistentry>

  <varlistentry>


this file looks good.

rycee

I like the idea! The Eclipse and Perl related links look OK.

rycee · 2017-10-29T10:16:37Z

pkgs/applications/editors/eclipse/build-eclipse.nix

@@ -53,7 +53,7 @@ stdenv.mkDerivation rec {
  ''; # */

  meta = {
-    homepage = http://www.eclipse.org/;
+    homepage = https://www.eclipse.org/;


rycee · 2017-10-29T10:17:07Z

pkgs/development/eclipse/ecj/default.nix

@@ -51,7 +51,7 @@ stdenv.mkDerivation rec {

    homepage = http://www.eclipse.org/jdt/core/index.php;

-    # http://www.eclipse.org/legal/epl-v10.html (free software, copyleft)
+    # https://www.eclipse.org/legal/epl-v10.html (free software, copyleft)


FRidh · 2018-02-11T07:35:32Z

I like the idea, but this is too large to review/test. In this case I think it is important to share the script that was used for making and testing this change. As it is now also outdated I am closing this.

iblech · 2018-02-11T09:48:28Z

Thank you @FRidh for your feedback! I'll convert this pull request into a (low-priority) issue and publish the script. It's just a couple of lines of good old Perl 5 code. :-)

treewide: use https addresses where possible

e5399ee

iblech requested review from edolstra, edwtjo, FRidh, peti and rycee as code owners October 28, 2017 20:33

grahamc reviewed Oct 29, 2017

View reviewed changes

rycee reviewed Oct 29, 2017

View reviewed changes

FRidh closed this Feb 11, 2018

iblech mentioned this pull request Feb 11, 2018

treewide: use https addresses where possible #34836

Closed

Profpatsch mentioned this pull request Mar 5, 2018

Use HTTPS for all URLs #13809

Closed

infinisil mentioned this pull request Apr 22, 2019

HTTPS urls #60010

Merged

10 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

treewide: use https addresses where possible #30906

treewide: use https addresses where possible #30906

iblech commented Oct 28, 2017

iblech commented Oct 28, 2017

grahamc left a comment

grahamc Oct 29, 2017

grahamc Oct 29, 2017

grahamc Oct 29, 2017

grahamc Oct 29, 2017

grahamc Oct 29, 2017

grahamc Oct 29, 2017

grahamc Oct 29, 2017

grahamc Oct 29, 2017

grahamc Oct 29, 2017

grahamc Oct 29, 2017

rycee left a comment

rycee Oct 29, 2017

rycee Oct 29, 2017

FRidh commented Feb 11, 2018

iblech commented Feb 11, 2018

treewide: use https addresses where possible #30906

treewide: use https addresses where possible #30906

Conversation

iblech commented Oct 28, 2017

Motivation for this change

Things done

iblech commented Oct 28, 2017

grahamc left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rycee left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

FRidh commented Feb 11, 2018

iblech commented Feb 11, 2018