Implement Digest::SHA256 #5197
Closed
Implement Digest::SHA256 #5197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Déjà vu: #2815 |
|
😮 😞 |
|
I'd rather not merge new crypto/openssl APIs before we think about redesigning the stdlib's crypto API in general. I think there should be a |
straight-shoota
added
kind:feature
topic:stdlib:crypto
pr:needs-work
straight-shoota
pushed a commit
that referenced
this pull request
Jun 17, 2021
* Add OpenSSL::SSL::Socket#peer_certificate * Add OpenSSL::X509::Certificate#signature_name and #5197 * Wrap OpenSSL linked functions in version guards * Update wording on OpenSSL::X509::Certificate#signature_algorithm error message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently Crystal only provides MD5 and SHA1 digests, which are both kind of deprecated and not recommended. Sure it is possible to use OpenSSL::Digest, but this pulls one big dependency for something that should be simple.
This pull request adds SHA256 to the game. The implementation could surely be more optimized, but this isn't the focus now, it can be improved later.
More algorithms could be implemented later, such as all variations of SHA-2 and SHA-3.