Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement EventTarget constructor #19283

Closed
KiChjang opened this issue Nov 19, 2017 · 4 comments · Fixed by #19288
Closed

Implement EventTarget constructor #19283

KiChjang opened this issue Nov 19, 2017 · 4 comments · Fixed by #19288
Labels
A-content/dom Interacting with the DOM from web content C-assigned There is someone working on resolving the issue E-less-complex Straightforward. Recommended for a new contributor. I-spec-update

Comments

@KiChjang
Copy link
Contributor

whatwg/dom#467

@KiChjang KiChjang added A-content/dom Interacting with the DOM from web content I-spec-update labels Nov 19, 2017
@KiChjang
Copy link
Contributor Author

Code: components/script/dom/EventTarget.rs, components/script/dom/webidl/EventTarget.webidl
Test: tests/wpt/web-platform-tests/dom/events/EventTarget-constructible.any.js

@KiChjang KiChjang added the E-less-complex Straightforward. Recommended for a new contributor. label Nov 19, 2017
@highfive
Copy link

Hi! If you have any questions regarding this issue, feel free to make a comment here, or ask it in the #servo channel in IRC.

If you intend to work on this issue, then add @highfive: assign me to your comment, and I'll assign this to you. 😄

@m-novikov
Copy link
Contributor

I would like to try it out. @highfive : assign me

@highfive
Copy link

Hey @m-novikov! Thanks for your interest in working on this issue. It's now assigned to you!

@highfive highfive added the C-assigned There is someone working on resolving the issue label Nov 19, 2017
m-novikov added a commit to m-novikov/servo that referenced this issue Nov 19, 2017
bors-servo pushed a commit that referenced this issue Nov 20, 2017
…jang

Implement EventTarget constructor

Resolves #19283
Do "Wrap" functions only created for elements that aren't marked Abstract in .webidl file?
How can I see code that was generated from webidls?

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #19283 (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [X] These changes do not require tests because they are covered by webplatform tests

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19288)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-content/dom Interacting with the DOM from web content C-assigned There is someone working on resolving the issue E-less-complex Straightforward. Recommended for a new contributor. I-spec-update
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants