Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.pyqt5: Add optional support for qtconnectivity #31819

Merged
merged 1 commit into from
Nov 21, 2017

Conversation

lrittel
Copy link
Contributor

@lrittel lrittel commented Nov 19, 2017

Motivation for this change

PyQt5 is missing the generated wrappers for the QtConnectivity module, which I needed for a private project.
The dependency is optional because most of the software using pyqt5 doesn't need the missing modules.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature. The key has expired.
rnhmjoj Michele Guerini Rocco
@lrittel lrittel requested a review from FRidh as a code owner November 19, 2017 10:29
@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Nov 19, 2017
@FRidh FRidh merged commit 8e3b8a6 into NixOS:master Nov 21, 2017
@lrittel lrittel deleted the pyqt-qtconnectivity branch November 23, 2017 12:42
@Janik-Haag Janik-Haag added the 12. first-time contribution This PR is the author's first one; please be gentle! label Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: python 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants