Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

documentation: python3Packages is python36Packages #31810

Closed
wants to merge 1 commit into from

Conversation

samueldr
Copy link
Member

Motivation for this change

From an IRC conversation, it seems the documentation wasn't updated in 66f7398

Ref: https://github.com/NixOS/nixpkgs/blob/release-17.09/pkgs/top-level/all-packages.nix#L6569

Question:

This will need to also be applied on master, should it have been instead targetting master and cherry-picked in 17.09?

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

I won't lie, this was edited through the Github interface, nothing was built.

@vcunat
Copy link
Member

vcunat commented Nov 19, 2017

Pushed to master and cherry-picked to 17.09, along with dropping 2.6 (that's the workflow we use).

@samueldr samueldr deleted the patch-2 branch March 18, 2018 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants