Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport nix-bash-completions #31836

Merged
merged 3 commits into from Nov 19, 2017
Merged

Backport nix-bash-completions #31836

merged 3 commits into from Nov 19, 2017

Conversation

bjornfor
Copy link
Contributor

Motivation for this change

nix-bash-completions is awesome and we need it in NixOS 17.09!

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@hedning @bjornfor
nix-bash-completions: init at 0.1
73fd717 
Bash completion for almost all nix* commands, including nix-1.12.

(cherry picked from commit 33ab98d)
@hedning @bjornfor
nix-bash-completions: 0.1 -> 0.2
f17e791 
Fix stray print debugging line which stopped the script from working.

(cherry picked from commit f8ca4db)
@hedning @bjornfor
nix-bash-completions: 0.2 -> 0.4
c769303 
A bunch of fixes, and now completes attribute paths when `<nixpkgs>`
syntax as file input.

(cherry picked from commit 53fbf7e)
@bjornfor bjornfor force-pushed the backport-nix-bash-completions branch from 93697e0 to c769303 Compare November 19, 2017 18:55
@bjornfor
Copy link
Contributor Author

cc @hedning

@fpletz fpletz added this to the 17.09 milestone Nov 19, 2017
fpletz
fpletz approved these changes Nov 19, 2017
View reviewed changes
Copy link
Member

@fpletz fpletz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Of course! 🎉

@bjornfor bjornfor merged commit c769303 into NixOS:release-17.09 Nov 19, 2017
@bjornfor bjornfor deleted the backport-nix-bash-completions branch November 19, 2017 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpletz fpletz fpletz approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
17.09
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bjornfor @fpletz @GrahamcOfBorg @hedning