nixos/doc/manual: print context on failing xmllint validation #31806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously only the line numbers of a giant, internally generated XML file were printed, without any kind of debuggability. Now at least the mentioned lines are printed with a little bit of surrounding context (to have something to grep for). ``` manual-combined.xml:4863: element para: Relax-NG validity error : Did not expect element para there 4859 <chapter xmlns="http://docbook.org/ns/docbook" xmlns:xlink="http://www.w3.org/1999/xlink" xmlns:xi="http://www.w3.org/2001/XInclude" version="5.0" xml:id="sec-writing-modules"> 4860 4861 <title>Writing NixOS Modules</title> 4862 4863 <para>NixOS has a modular system for declarative configuration. This 4864 system combines multiple <emphasis>modules</emphasis> to produce the 4865 full system configuration. One of the modules that constitute the ```
Profpatsch
force-pushed
the
xmllint-context
branch
from
f4d0360
to
7a90aca
Compare
|
Update: added comments, print to stderr like the original xmllint output. |
|
I love the output, I don't love that we have to do it ourselves. Can you think of an easy way to apply this to the nixpkgs docs too? |
Should be possible, but we already use afaik that gives better output. See #14320 |
|
@grahamc Do you think we can merge? |
|
Yes
…On Wed 22. Nov 2017 at 15:18, Profpatsch ***@***.***> wrote:
@grahamc <https://github.com/grahamc> Do you think we can merge?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#31806 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAErrG0NSDo17vz8CyKaTOjGRn3DF3uEks5s5IGggaJpZM4QjMfM>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously only the line numbers of a giant, internally generated XML file were
printed, without any kind of debuggability.
Now at least the mentioned lines are printed with a little bit of surrounding
context (to have something to grep for).