newsboat: init at 2.10.1 #31802
Closed
newsboat: init at 2.10.1 #31802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicknovitski
force-pushed
the
newsboat
branch
4 times, most recently
from
d8bb531
to
6fc5083
Compare
Ma27
reviewed
Nov 19, 2017
| ++ stdenv.lib.optional stdenv.isDarwin makeWrapper; | ||
|
|
||
| preBuild = '' | ||
| substituteInPlace config.sh \ |
There was a problem hiding this comment.
I guess that for patching files in a package the patchPhase should preferably be used
There was a problem hiding this comment.
postPatch, overriding patchPhase prevents usage of patches = attribute.
| done | ||
| ''; | ||
|
|
||
| meta = { |
There was a problem hiding this comment.
most of the derivations use meta = with stdenv.lib; { which makes the expression less verbose as you don't have to type stdenv.lib.{any-value} all the time.
|
btw I cecked out your branch and ran |
Based on newsbeuter package.
nicknovitski
force-pushed
the
newsboat
branch
from
6fc5083
to
ff3dcbb
Compare
|
Thanks for that @Ma27. I changed the replacements to happen in postPatch and cleaned up meta like you suggested. |
|
@GrahamcOfBorg build newsboat |
There was a problem hiding this comment.
Failure for system: x86_64-linux
ranlib libfilter.a
g++ -std=c++11 -ggdb -Iinclude -Istfl -Ifilter -I. -Irss -Werror -Wall -Wextra -Wunreachable-code -DLOCALEDIR=\"/usr/local/share/locale\" -I/nix/store/9c0dxmn0ch9hbac2il4jk0g0hf2bg4h2-sqlite-3.21.0-dev/include -I/nix/store/5afp87hdnsw0a4b96i1iv6wcf455mhh6-curl-7.56.1-dev/include -I/nix/store/avkk0fxind45lzhc4khf6w3kzkvqflp5-libxml2-2.9.5-dev/include/libxml2 -I/include -I/nix/store/kxnwq950l1456w0zmsnv11bwfg9j31px-json-c-0.11/include/json-c -D_GNU_SOURCE -D_DEFAULT_SOURCE -I/nix/store/ks518vijnzqdzlvhf8da2szkn6xwdwg1-ncurses-6.0-20170902-dev/include -o newsbeuter.o -c newsbeuter.cpp
g++ -std=c++11 -ggdb -Iinclude -Istfl -Ifilter -I. -Irss -Werror -Wall -Wextra -Wunreachable-code -DLOCALEDIR=\"/usr/local/share/locale\" -I/nix/store/9c0dxmn0ch9hbac2il4jk0g0hf2bg4h2-sqlite-3.21.0-dev/include -I/nix/store/5afp87hdnsw0a4b96i1iv6wcf455mhh6-curl-7.56.1-dev/include -I/nix/store/avkk0fxind45lzhc4khf6w3kzkvqflp5-libxml2-2.9.5-dev/include/libxml2 -I/include -I/nix/store/kxnwq950l1456w0zmsnv11bwfg9j31px-json-c-0.11/include/json-c -D_GNU_SOURCE -D_DEFAULT_SOURCE -I/nix/store/ks518vijnzqdzlvhf8da2szkn6xwdwg1-ncurses-6.0-20170902-dev/include -o src/cache.o -c src/cache.cpp
g++ -std=c++11 -ggdb -Iinclude -Istfl -Ifilter -I. -Irss -Werror -Wall -Wextra -Wunreachable-code -DLOCALEDIR=\"/usr/local/share/locale\" -I/nix/store/9c0dxmn0ch9hbac2il4jk0g0hf2bg4h2-sqlite-3.21.0-dev/include -I/nix/store/5afp87hdnsw0a4b96i1iv6wcf455mhh6-curl-7.56.1-dev/include -I/nix/store/avkk0fxind45lzhc4khf6w3kzkvqflp5-libxml2-2.9.5-dev/include/libxml2 -I/include -I/nix/store/kxnwq950l1456w0zmsnv11bwfg9j31px-json-c-0.11/include/json-c -D_GNU_SOURCE -D_DEFAULT_SOURCE -I/nix/store/ks518vijnzqdzlvhf8da2szkn6xwdwg1-ncurses-6.0-20170902-dev/include -o src/htmlrenderer.o -c src/htmlrenderer.cpp
g++ -std=c++11 -ggdb -Iinclude -Istfl -Ifilter -I. -Irss -Werror -Wall -Wextra -Wunreachable-code -DLOCALEDIR=\"/usr/local/share/locale\" -I/nix/store/9c0dxmn0ch9hbac2il4jk0g0hf2bg4h2-sqlite-3.21.0-dev/include -I/nix/store/5afp87hdnsw0a4b96i1iv6wcf455mhh6-curl-7.56.1-dev/include -I/nix/store/avkk0fxind45lzhc4khf6w3kzkvqflp5-libxml2-2.9.5-dev/include/libxml2 -I/include -I/nix/store/kxnwq950l1456w0zmsnv11bwfg9j31px-json-c-0.11/include/json-c -D_GNU_SOURCE -D_DEFAULT_SOURCE -I/nix/store/ks518vijnzqdzlvhf8da2szkn6xwdwg1-ncurses-6.0-20170902-dev/include -o src/urlreader.o -c src/urlreader.cpp
./txt2h.pl stfl/itemlist.stfl .stfl > stfl/itemlist.h
/nix/store/4ada72n7785wwazv42fhsnxjvilaa3aj-bash-4.4-p12/bin/bash: ./txt2h.pl: /usr/bin/env: bad interpreter: No such file or directory
make: *** [Makefile:115: stfl/itemlist.h] Error 126
builder for ‘/nix/store/fz6q9y4bl0ibj08nwigjxw469yrhfbbj-newsboat-2.10.1.drv’ failed with exit code 2
error: build of ‘/nix/store/fz6q9y4bl0ibj08nwigjxw469yrhfbbj-newsboat-2.10.1.drv’ failed
|
Hmm looks like a bit more work needed around the usr/bin/env references. |
There was a problem hiding this comment.
Success for system: x86_64-darwin
gzipping man pages under /nix/store/qhn5jyh4qyqzf0y9pwsbsikds5hnj5ib-newsboat-2.10.1/share/man/
stripping (with flags -S) in /nix/store/qhn5jyh4qyqzf0y9pwsbsikds5hnj5ib-newsboat-2.10.1/bin
patching script interpreter paths in /nix/store/qhn5jyh4qyqzf0y9pwsbsikds5hnj5ib-newsboat-2.10.1
/nix/store/qhn5jyh4qyqzf0y9pwsbsikds5hnj5ib-newsboat-2.10.1/contrib/bookmark-delicious.sh: interpreter directive changed from "/bin/sh" to "/nix/store/hh833qm6lgb6cgr7z9vxkb72wikr4wwz-bash-4.4-p12/bin/sh"
/nix/store/qhn5jyh4qyqzf0y9pwsbsikds5hnj5ib-newsboat-2.10.1/contrib/bookmark-pinboard.sh: interpreter directive changed from "/bin/sh" to "/nix/store/hh833qm6lgb6cgr7z9vxkb72wikr4wwz-bash-4.4-p12/bin/sh"
/nix/store/qhn5jyh4qyqzf0y9pwsbsikds5hnj5ib-newsboat-2.10.1/contrib/bookmark-scuttle.sh: interpreter directive changed from "/bin/sh" to "/nix/store/hh833qm6lgb6cgr7z9vxkb72wikr4wwz-bash-4.4-p12/bin/sh"
/nix/store/qhn5jyh4qyqzf0y9pwsbsikds5hnj5ib-newsboat-2.10.1/contrib/getpocket.com/create-pocket-user-token.sh: interpreter directive changed from "/bin/sh" to "/nix/store/hh833qm6lgb6cgr7z9vxkb72wikr4wwz-bash-4.4-p12/bin/sh"
/nix/store/qhn5jyh4qyqzf0y9pwsbsikds5hnj5ib-newsboat-2.10.1/contrib/getpocket.com/send-to-pocket.sh: interpreter directive changed from "/bin/bash" to "/nix/store/hh833qm6lgb6cgr7z9vxkb72wikr4wwz-bash-4.4-p12/bin/bash"
/nix/store/qhn5jyh4qyqzf0y9pwsbsikds5hnj5ib-newsboat-2.10.1/contrib/pinboard.pl: interpreter directive changed from "/usr/bin/env perl" to "/nix/store/34r0w11jh1kgnvdlqnnk5h2vnm0qmnl3-perl-5.24.3/bin/perl"
/nix/store/qhn5jyh4qyqzf0y9pwsbsikds5hnj5ib-newsboat-2.10.1
|
@nicknovitski Thank you, I coudn't figure out how to get the manpages working. Your approach seems to work. |
|
@tasmo No problem, congrats on your first contribution! |
|
@nicknovitski Thank you! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fork of newsbeuter, which is now unmaintained.
Things done
build-use-sandboxinnix.confon non-NixOS)[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)[ ] Tested compilation of all pkgs that depend on this change usingnix-shell -p nox --run "nox-review wip"./result/bin/)