Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

melpaStablePackages.caml: don't run configure #31798

Merged
merged 1 commit into from Mar 22, 2018

Conversation

catern
Copy link
Contributor

@catern catern commented Nov 18, 2017

Motivation for this change

The caml-mode package is extracted by Melpa from the full Ocaml repository. That repository contains a file called "configure" with non-standard arguments, which is not needed to build/extract the Emacs mode. Nevertheless we automatically run configure as part of configurePhase, and it breaks due to the non-standard arguments, which breaks the build as a whole.

I don't think is the correct way to disable configurePhase, but this at least works on my system.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants