nixos/matrix-synapse: make home directory configurable #31812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fpletz
reviewed
Nov 19, 2017
| @@ -44,7 +44,7 @@ database: { | |||
| } | |||
| event_cache_size: "${cfg.event_cache_size}" | |||
| verbose: ${cfg.verbose} | |||
| log_file: "/var/log/matrix-synapse/homeserver.log" | |||
| log_file: "${cfg.dataDir}/homeserver.log" | |||
There was a problem hiding this comment.
Do we even want a separate logfile? All logs are going to the systemd jorunal anyways.
There was a problem hiding this comment.
@fpletz I don't have strong feelings either way - should I amend this PR or make another one to remove it?
There was a problem hiding this comment.
I think two separate commits for to unrealted changes should do, however I don't think that it's necessary to even open another PR :)
fpletz
approved these changes
Nov 20, 2017
|
Thanks!
…On 20 November 2017 7:06:01 pm ACDT, Franz Pletz ***@***.***> wrote:
Merged #31812.
--
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
#31812 (comment)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Just want to save my home server's data in a non-standard spot.
The default is the same as it was before so existing users won't be affected.
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)