Update background-size example #339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
I've also chosen a different image
Works for me. I am wondering though if perhaps we want to add all the images used in examples inside a examples folder inside media to keep em separated ;p Also, its worth running these images through either ImageOptim or http://tinypng.com
These should be done now. Good call on moving the images, it did occur to me that this would get messy, but I didn't follow the thought through. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here are some updates to the background-size example.
The original example is too tall to fit without scrolling, so I've reduced the vertical height to prevent that:
removed comments: I think the code is pretty self-explanatory, and given how precious vertical space is, we should avoid comments unless they are really needed
removed one of the examples, which covered quite similar ground to another one
I've also chosen a different image: I chose this for a few reasons:
the aspect seems like it will work better to show the difference between keywords like
coverandcontainthe shape is very simple and recognizable, so distortions when you set width and height are more obvious
I'm happy to talk about these changes though if you don't agree.