minikube: Add vmnet as buildInput on darwin #31830
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should fix NixOS#30133.
|
Saw that the fix just landed in master a4d7b6a, guess I'll just close this one 😄 |
|
Oh I'm sorry, I missed this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #30133.
Motivation for this change
Just upgraded minikube on my darwin box and ran into #30133. When comparing to the xhyve derivation I found that the build input vmnet was not declared and gave it a shot. This did the trick for me and allowed me be build the current minikube on my darwin box.
Things done
build-use-sandboxinnix.confon non-NixOS)nix-build -A minikube --argstr system x86_64-linux, did only fetch binaries)nix-shell -p nox --run "nox-review wip"result-bin/bin/minikube