Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sdcv: enable Darwin build #31803

Merged
merged 1 commit into from Nov 20, 2017
Merged

sdcv: enable Darwin build #31803

merged 1 commit into from Nov 20, 2017

Conversation

nicknovitski
Copy link
Contributor

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • [ ] NixOS
    • macOS
    • [ ] other Linux distributions
  • [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • [ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@LnL7
Copy link
Member

LnL7 commented Nov 19, 2017

@GrahamcOfBorg build sdcv

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failure for system: x86_64-darwin

error: undefined variable ‘sandbox’ at /Users/graham/nix-tests-rs/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/31803/pkgs/development/interpreters/perl/default.nix:47:22
(use ‘--show-trace’ to show detailed location information)

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success for system: x86_64-linux

-- Installing: /nix/store/870nd312a03li137230cmmrc5az2sc2s-sdcv-0.5.2/share/locale
glibPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/870nd312a03li137230cmmrc5az2sc2s-sdcv-0.5.2
shrinking /nix/store/870nd312a03li137230cmmrc5az2sc2s-sdcv-0.5.2/bin/sdcv
gzipping man pages under /nix/store/870nd312a03li137230cmmrc5az2sc2s-sdcv-0.5.2/share/man/
stripping (with flags -S) in /nix/store/870nd312a03li137230cmmrc5az2sc2s-sdcv-0.5.2/bin 
patching script interpreter paths in /nix/store/870nd312a03li137230cmmrc5az2sc2s-sdcv-0.5.2
checking for references to /tmp/nix-build-sdcv-0.5.2.drv-0 in /nix/store/870nd312a03li137230cmmrc5az2sc2s-sdcv-0.5.2...
/nix/store/870nd312a03li137230cmmrc5az2sc2s-sdcv-0.5.2

orivej added a commit that referenced this pull request Nov 19, 2017
This reverts commit 9ee089a.

0fe7bde is not in master yet and it would break
master if it were: #31803 (review)
@orivej
Copy link
Contributor

orivej commented Nov 19, 2017

@GrahamcOfBorg build sdcv

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failure for system: x86_64-darwin

error: undefined variable ‘sandbox’ at /Users/graham/nix-tests-rs/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/31803/pkgs/development/interpreters/perl/default.nix:47:22
(use ‘--show-trace’ to show detailed location information)

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success for system: x86_64-linux

-- Installing: /nix/store/870nd312a03li137230cmmrc5az2sc2s-sdcv-0.5.2/share/locale
glibPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/870nd312a03li137230cmmrc5az2sc2s-sdcv-0.5.2
shrinking /nix/store/870nd312a03li137230cmmrc5az2sc2s-sdcv-0.5.2/bin/sdcv
gzipping man pages under /nix/store/870nd312a03li137230cmmrc5az2sc2s-sdcv-0.5.2/share/man/
stripping (with flags -S) in /nix/store/870nd312a03li137230cmmrc5az2sc2s-sdcv-0.5.2/bin 
patching script interpreter paths in /nix/store/870nd312a03li137230cmmrc5az2sc2s-sdcv-0.5.2
checking for references to /tmp/nix-build-sdcv-0.5.2.drv-0 in /nix/store/870nd312a03li137230cmmrc5az2sc2s-sdcv-0.5.2...
/nix/store/870nd312a03li137230cmmrc5az2sc2s-sdcv-0.5.2

@LnL7
Copy link
Member

LnL7 commented Nov 19, 2017

@orivej
Copy link
Contributor

orivej commented Nov 19, 2017

@LnL7 Yes, this is my fault, 9ee089a should have gone to staging (already did) where this attribute is deleted.

@LnL7
Copy link
Member

LnL7 commented Nov 19, 2017

Ah, thought maybe staging was merged.

@LnL7
Copy link
Member

LnL7 commented Nov 20, 2017

@GrahamcOfBorg build sdcv

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success for system: x86_64-darwin

-- Installing: /nix/store/ah1xk4casz2pqgd3rgs47h0c966337sw-sdcv-0.5.2/bin/sdcv
-- Installing: /nix/store/ah1xk4casz2pqgd3rgs47h0c966337sw-sdcv-0.5.2/share/man/man1/sdcv.1
-- Installing: /nix/store/ah1xk4casz2pqgd3rgs47h0c966337sw-sdcv-0.5.2/share/man/uk/man1/sdcv.1
-- Installing: /nix/store/ah1xk4casz2pqgd3rgs47h0c966337sw-sdcv-0.5.2/share/locale
glibPreFixupPhase
post-installation fixup
gzipping man pages under /nix/store/ah1xk4casz2pqgd3rgs47h0c966337sw-sdcv-0.5.2/share/man/
stripping (with flags -S) in /nix/store/ah1xk4casz2pqgd3rgs47h0c966337sw-sdcv-0.5.2/bin
patching script interpreter paths in /nix/store/ah1xk4casz2pqgd3rgs47h0c966337sw-sdcv-0.5.2
/nix/store/ah1xk4casz2pqgd3rgs47h0c966337sw-sdcv-0.5.2

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success for system: x86_64-linux

-- Installing: /nix/store/870nd312a03li137230cmmrc5az2sc2s-sdcv-0.5.2/share/locale
glibPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/870nd312a03li137230cmmrc5az2sc2s-sdcv-0.5.2
shrinking /nix/store/870nd312a03li137230cmmrc5az2sc2s-sdcv-0.5.2/bin/sdcv
gzipping man pages under /nix/store/870nd312a03li137230cmmrc5az2sc2s-sdcv-0.5.2/share/man/
stripping (with flags -S) in /nix/store/870nd312a03li137230cmmrc5az2sc2s-sdcv-0.5.2/bin 
patching script interpreter paths in /nix/store/870nd312a03li137230cmmrc5az2sc2s-sdcv-0.5.2
checking for references to /tmp/nix-build-sdcv-0.5.2.drv-0 in /nix/store/870nd312a03li137230cmmrc5az2sc2s-sdcv-0.5.2...
/nix/store/870nd312a03li137230cmmrc5az2sc2s-sdcv-0.5.2

@LnL7 LnL7 added the 6.topic: darwin Running or building packages on Darwin label Nov 20, 2017
@LnL7 LnL7 merged commit b7dac50 into NixOS:master Nov 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants