Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gdm: start gdm on tty7 rather than default tty1 #31820

Closed
wants to merge 3 commits into from
Closed

gdm: start gdm on tty7 rather than default tty1 #31820

wants to merge 3 commits into from

Conversation

pierrechevalier83
Copy link
Contributor

@pierrechevalier83 pierrechevalier83 commented Nov 19, 2017 •
edited

Motivation for this change

I can't use nixos-rebuild switch at the moment. I was waiting for someone else to create a pull request, but I thought I might as well.

Things done

As per comments on ticket, went for solution that was brought forward by @deedrah and @bjornfor: start gdm on tty7.
Tested and works for me with gnome 3.24 + gdm + X11.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@pierrechevalier83
gdm: start gdm on tty7 rather than default tty1
dbea806 
- Fixes nixos-rebuild switch/test issue with GNOME
  NixOS#21439
- The solution was given here:
  roastiek@d761e66#commitcomment-25382880
@bjornfor
Copy link
Contributor

Thanks! I'm running the NixOS tests now. If they pass I'll merge. (I don't have a NixOS machine on master branch.)

@bjornfor
Copy link
Contributor

nix-build nixos/tests/gnome3-gdm.nix fails on my system. But it also fails on master. Looking at hydra.nixos.org I see nixos.tests.gnome3-gdm failed, but due to "Cancelled by user". Hm...

On my system the test times out after printing this block of test repeatedly for a long time:

machine: must succeed: xwininfo -root -tree | sed 's/.*0x[0-9a-f]* \"\([^\"]*\)\".*/\1/; t; d'
machine# No protocol specified
machine# xwininfo: error: unable to open display ":0.0"
machine: exit status 0

Anyway, I think we can revert 440178d ("gdm: don't start getty@tty1 if enabled"), and remove the other lines regarding "getty@tty1" in nixos/modules/services/x11/display-managers/gdm.nix.

@pierrechevalier83
Revert "gdm: don't start getty@tty1 if enabled"
38a18e5 
This commit isn't needed anymore since we now run gdm on tty7.

This reverts commit 440178d.
@pierrechevalier83
gdm: remove old workaround for conflicts with getty
69aefc8 
- There used to be a conflict between gdm and getty both trying to
  access tty1
- This conflict was fixed by running gdm on tty7 instead
@pierrechevalier83
Copy link
Contributor Author

Thanks for the review @bjornfor. I've removed the references to getty. Things still seem to work for me 😄

@bjornfor
Copy link
Contributor

Yep, since the tests not working on my system is not a regression, I don't think it should block integration.

@vcunat vcunat added the 6.topic: GNOME GNOME desktop environment and its underlying platform label Nov 19, 2017
@vcunat
Copy link
Member

vcunat commented Nov 19, 2017

/cc @jtojnar.

jtojnar
jtojnar approved these changes Nov 19, 2017
View reviewed changes
Copy link
Contributor

@jtojnar jtojnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really my area of expertise but it seems to work with GNOME 3.26.

@bjornfor
Copy link
Contributor

Applied to master (c46d4da and 2 parents). Thanks!

@bjornfor bjornfor closed this Nov 19, 2017
@jtojnar jtojnar mentioned this pull request Nov 20, 2017
Merged
8 tasks
@ius ius mentioned this pull request Oct 17, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjornfor bjornfor bjornfor approved these changes

@jtojnar jtojnar jtojnar approved these changes

Assignees
No one assigned
Labels
6.topic: GNOME GNOME desktop environment and its underlying platform 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@pierrechevalier83 @bjornfor @vcunat @jtojnar @GrahamcOfBorg