Skip to content

Commit

Permalink
minikube: fix build on Darwin
Browse files Browse the repository at this point in the history
Fixes #30133
  • Loading branch information
copumpkin committed Nov 19, 2017
1 parent 528bf1b commit a4d7b6a
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 3 deletions.
4 changes: 2 additions & 2 deletions pkgs/applications/networking/cluster/minikube/default.nix
@@ -1,5 +1,5 @@
{ stdenv, buildGoPackage, fetchFromGitHub, fetchurl, go-bindata, kubernetes, libvirt, qemu, docker-machine-kvm,
gpgme, makeWrapper }:
gpgme, makeWrapper, hostPlatform, vmnet }:

let
binPath = [ kubernetes ]
Expand Down Expand Up @@ -36,7 +36,7 @@ in buildGoPackage rec {

# kubernetes is here only to shut up a loud warning when generating the completions below. minikube checks very eagerly
# that kubectl is on the $PATH, even if it doesn't use it at all to generate the completions
buildInputs = [ go-bindata makeWrapper kubernetes gpgme ];
buildInputs = [ go-bindata makeWrapper kubernetes gpgme ] ++ stdenv.lib.optional hostPlatform.isDarwin vmnet;
subPackages = [ "cmd/minikube" ];

preBuild = ''
Expand Down
4 changes: 3 additions & 1 deletion pkgs/top-level/all-packages.nix
Expand Up @@ -15663,7 +15663,9 @@ with pkgs;

minidjvu = callPackage ../applications/graphics/minidjvu { };

minikube = callPackage ../applications/networking/cluster/minikube { };
minikube = callPackage ../applications/networking/cluster/minikube {
inherit (darwin.apple_sdk.frameworks) vmnet;
};

minitube = callPackage ../applications/video/minitube { };

Expand Down

0 comments on commit a4d7b6a

Please sign in to comment.