Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move font-feature-settings outside of mako. #19290

Closed
CYBAI opened this issue Nov 19, 2017 · 1 comment · Fixed by #19293
Closed

Move font-feature-settings outside of mako. #19290

CYBAI opened this issue Nov 19, 2017 · 1 comment · Fixed by #19293

Comments

@CYBAI
Copy link
Member

CYBAI commented Nov 19, 2017

I'll take this one as a sub-issue of #19015
@tigercosmos
Copy link
Contributor

thanks for your patient to do these works 👍

@emilio emilio mentioned this issue Nov 19, 2017
Closed
49 tasks
@CYBAI CYBAI mentioned this issue Nov 20, 2017
Merged
4 tasks
bors-servo pushed a commit that referenced this issue Nov 20, 2017
Auto merge of #19293 - CYBAI:font-feature-settings-out-of-mako, r=emilio
9edb453 
style: Move font-feature-settings outside of mako

This is a sub-PR of #19015
r? emilio

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #19290
- [x] These changes do not require tests

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19293)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

style: Move font-feature-settings outside of mako CYBAI/servo
2 participants
@CYBAI @tigercosmos