cleanup: Use RangeFrom rather than custom Incrementor
#181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use standard library functionality instead of custom class. When I reviewed the PR that originally introduced this, it *did* feel wrong to me to implement such a generic helper class in our code... But for some reason it didn't occur to me that a simple range iterator is the obvious answer.
|
cc @dlrobertson |
|
@bors-servo r+ |
|
📌 Commit 433bd51 has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Nov 22, 2017
cleanup: Use `RangeFrom` rather than custom `Incrementor` Use standard library functionality instead of custom class. When I reviewed the PR that originally introduced this, it *did* feel wrong to me to implement such a generic helper class in our code... But for some reason it didn't occur to me that a simple range iterator is the obvious answer.
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use standard library functionality instead of custom class.
When I reviewed the PR that originally introduced this, it did feel
wrong to me to implement such a generic helper class in our code... But
for some reason it didn't occur to me that a simple range iterator is
the obvious answer.