Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate ptr::null rather than zero literal #1157

Merged
merged 1 commit into from Nov 20, 2017
Merged

Generate ptr::null rather than zero literal #1157

merged 1 commit into from Nov 20, 2017

Conversation

tamird
Copy link
Contributor

@tamird tamird commented Nov 19, 2017

No description provided.

Copy link
Contributor

@emilio emilio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine, but can I ask what's the motivation for this change?

@tamird
Copy link
Contributor Author

tamird commented Nov 19, 2017

Clippy complains about this in crates that use clippy. Easy to ignore, but thought I'd fix it for everyone.

Copy link
Contributor

@emilio emilio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, thanks!

@emilio
Copy link
Contributor

emilio commented Nov 20, 2017

@bors-servo r+

@bors-servo
Copy link

📌 Commit 430fb0e has been approved by emilio

@bors-servo
Copy link

⌛ Testing commit 430fb0e with merge e3e6c73...

bors-servo pushed a commit that referenced this pull request Nov 20, 2017
Generate ptr::null rather than zero literal
@bors-servo
Copy link

☀️ Test successful - status-travis
Approved by: emilio
Pushing e3e6c73 to master...

@bors-servo bors-servo merged commit 430fb0e into rust-lang:master Nov 20, 2017
@tamird tamird deleted the use-ptr-null branch November 20, 2017 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants