screenfetch: fix darwin execution #31814
Merged
+19
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LnL7
approved these changes
Nov 19, 2017
| coreutils gawk procps gnused findutils xdpyinfo | ||
| xprop gnugrep ncurses bc | ||
| ]} | ||
| --set PATH ${lib.makeBinPath ([ |
There was a problem hiding this comment.
Using --suffix will prefix PATH instead of overriding it, then the wrapper won't need things like coreutils that are always available.
There was a problem hiding this comment.
Yep that would work although prefix might be better. Eventual goal is to get rid of all /usr/bin stuff and make it all "pure" NixOS (although now I've realized that system_profiler and defaults for instance are not even available in opensource.apple.com)
There was a problem hiding this comment.
Actually I think I'll leave it as is. That way we don't have to have a separate installPhase for linux vs darwin.
|
@GrahamcOfBorg build screenfetch |
There was a problem hiding this comment.
Success for system: x86_64-darwin
building
no Makefile, doing nothing
installing
patching script interpreter paths in /nix/store/d6yavygnkjpbpdmz0yawa73qp7xi18v2-screenFetch-2016-10-11/bin/screenfetch
/nix/store/d6yavygnkjpbpdmz0yawa73qp7xi18v2-screenFetch-2016-10-11/bin/screenfetch: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/hh833qm6lgb6cgr7z9vxkb72wikr4wwz-bash-4.4-p12/bin/bash"
post-installation fixup
gzipping man pages under /nix/store/d6yavygnkjpbpdmz0yawa73qp7xi18v2-screenFetch-2016-10-11/share/man/
stripping (with flags -S) in /nix/store/d6yavygnkjpbpdmz0yawa73qp7xi18v2-screenFetch-2016-10-11/bin
patching script interpreter paths in /nix/store/d6yavygnkjpbpdmz0yawa73qp7xi18v2-screenFetch-2016-10-11
/nix/store/d6yavygnkjpbpdmz0yawa73qp7xi18v2-screenFetch-2016-10-11
There was a problem hiding this comment.
Success for system: x86_64-linux
installing
patching script interpreter paths in /nix/store/h4z9yanyqzsvfg4ax2iyzhm3lyzn0x2s-screenFetch-2016-10-11/bin/screenfetch
/nix/store/h4z9yanyqzsvfg4ax2iyzhm3lyzn0x2s-screenFetch-2016-10-11/bin/screenfetch: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/4ada72n7785wwazv42fhsnxjvilaa3aj-bash-4.4-p12/bin/bash"
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/h4z9yanyqzsvfg4ax2iyzhm3lyzn0x2s-screenFetch-2016-10-11
gzipping man pages under /nix/store/h4z9yanyqzsvfg4ax2iyzhm3lyzn0x2s-screenFetch-2016-10-11/share/man/
stripping (with flags -S) in /nix/store/h4z9yanyqzsvfg4ax2iyzhm3lyzn0x2s-screenFetch-2016-10-11/bin
patching script interpreter paths in /nix/store/h4z9yanyqzsvfg4ax2iyzhm3lyzn0x2s-screenFetch-2016-10-11
checking for references to /tmp/nix-build-screenFetch-2016-10-11.drv-0 in /nix/store/h4z9yanyqzsvfg4ax2iyzhm3lyzn0x2s-screenFetch-2016-10-11...
/nix/store/h4z9yanyqzsvfg4ax2iyzhm3lyzn0x2s-screenFetch-2016-10-11
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #31790
Things done
nix-shell -p nox --run "nox-review wip"./result/bin/)