Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sqlite-jdbc: init at 3.20.0 #31816

Merged
merged 1 commit into from Nov 20, 2017
Merged

Conversation

jraygauthier
Copy link
Member

Motivation for this change

Missing jdbc driver. Used with the shemaspy package which has its own PR: #31815.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Tested indirectly via schemaspy.

buildInputs = [
];

buildPhase = "true";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that either dontBuild = true or phases = [ "installPhase" ] is a more suitablesolution

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like good advice, will do.

@Mic92 Mic92 changed the title sqlite-jdbc: Init at 3.20.0 sqlite-jdbc: init at 3.20.0 Nov 19, 2017
@Mic92
Copy link
Member

Mic92 commented Nov 19, 2017

How is this project supposed to be used? (since no executable is included)

@grahamc
Copy link
Member

grahamc commented Nov 20, 2017

@GrahamcOfBorg build sqlite-jdbc

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success for system: x86_64-linux

patching sources
configuring
no configure script, doing nothing
building
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/2jfnypc64myx56mdcksqkw5vq9s9fk8l-sqlite-jdbc-3.20.0
patching script interpreter paths in /nix/store/2jfnypc64myx56mdcksqkw5vq9s9fk8l-sqlite-jdbc-3.20.0
checking for references to /tmp/nix-build-sqlite-jdbc-3.20.0.drv-0 in /nix/store/2jfnypc64myx56mdcksqkw5vq9s9fk8l-sqlite-jdbc-3.20.0...
/nix/store/2jfnypc64myx56mdcksqkw5vq9s9fk8l-sqlite-jdbc-3.20.0

@jraygauthier
Copy link
Member Author

@Mic92:

This is a jdbc driver. It should be use like mysql_jdbc and postgresql_jdbc. A
hypothetical example:

  squirrel-sql = callPackage ../development/tools/database/squirrel-sql {
    drivers = [ mysql_jdbc postgresql_jdbc sqlite-jdbc ];
  };

The drivers will get brought in CLASSPATH and used by the executable. It can also be loaded dynamically as with:

schemaspy -t sqlite2 -dp /nix/store/gmdv9vva8gc42h0plhafzmic0d5rgn29-sqlite-jdbc-3.20.0/share/java/sqlite-jdbc-3.20.0.jar

Also, when added as buildInputs, it should automatically get part of CLASSPATH.

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success for system: x86_64-darwin

building ‘/nix/store/0kvyz5k02q7ir8y9r1c1dnwbvwgwrbfw-sqlite-jdbc-3.20.0.drv’ on ‘mac1’
unpacking sources
patching sources
configuring
no configure script, doing nothing
building
installing
post-installation fixup
patching script interpreter paths in /nix/store/fh24bhw0xdnzi6lgh8dps7qadn5c9jd9-sqlite-jdbc-3.20.0
/nix/store/fh24bhw0xdnzi6lgh8dps7qadn5c9jd9-sqlite-jdbc-3.20.0

@jraygauthier
Copy link
Member Author

Changes applied as suggested by @Ma27 .

@Mic92 Mic92 merged commit 3f057db into NixOS:master Nov 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants