-
-
Notifications
You must be signed in to change notification settings - Fork 15.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix source root locations. #31132
fix source root locations. #31132
Conversation
sourceRoot = "source/source"; | ||
setSourceRoot = '' | ||
sourceRoot=$(echo */source) | ||
''; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's been suggested not to use "source" directly - #31106 (comment) - hence I changed it as per the comment.
sourceRoot = "source/src/unetbootin"; | ||
setSourceRoot = '' | ||
sourceRoot=$(echo */src/unetbootin) | ||
''; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's been suggested not to use "source" directly - #31106 (comment) - hence I changed it as per the comment.
sourceRoot = "source/Unix"; | ||
setSourceRoot = '' | ||
sourceRoot=$(echo */Unix) | ||
''; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's been suggested not to use "source" directly - #31106 (comment) - hence I changed it as per the comment.
}) | ||
(fetchFromGitHub { | ||
owner = "dlang"; | ||
repo = "phobos"; | ||
rev = "v${version}"; | ||
sha256 = "0fywgds9xvjcgnqxmpwr67p3wi2m535619pvj159cgwv5y0nr3p1"; | ||
name = "phobos-v${version}-src"; | ||
}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unsure if this is proper way to deal with derivation with multiple sources.
}) | ||
(fetchFromGitHub { | ||
owner = "dlang"; | ||
repo = "phobos"; | ||
rev = "v${version}"; | ||
sha256 = "1a7q5fd15yspgs5plxgx54jyrcwgzlyw3rahmz04jd2s5h56dj04"; | ||
name = "phobos-v${version}-src"; | ||
}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unsure if this is proper way to deal with derivation with multiple sources.
}) | ||
(fetchFromGitHub { | ||
owner = "ldc-developers"; | ||
repo = "dmd-testsuite"; | ||
rev = "ldc-v${version}"; | ||
sha256 = "0dmdkp220gqhxjrmrjfkf0vsvylwfaj70hswavq4q3v4dg17pzmj"; | ||
name = "dmd-testsuite-ldc-v${version}-src"; | ||
}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unsure if this is proper way to deal with derivation with multiple sources.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed with nox-review
. Thank you very much!
These have changed following commit c3255fe.
See also:
Motivation for this change
Things done
build-use-sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)