dropbox: use buildFHSUserEnv #31140
Merged
dropbox: use buildFHSUserEnv #31140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of adapting Dropbox to NixOS with patchelf, NixOS is adapted to Dropbox with an FHS user environment. A crash due to missing libXert (NixOS#15356) is fixed. The client's automatic updater is fixed; this obviates the need to update Dropbox in Nixpkgs every time the client is updated upstream! Resolves: NixOS#15356
ttuegel
added
0.kind: bug
0.kind: enhancement
8.has: package (update)
9.needs: port to stable
|
The CI tests pass on Linux. I cancelled the tests on macOS because it is not in |
samueldr
removed
the
9.needs: port to stable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of adapting Dropbox to NixOS with patchelf, NixOS is adapted to Dropbox
with an FHS user environment. A crash due to missing libXert (#15356) is
fixed. The client's automatic updater is fixed; this obviates the need to
update Dropbox in Nixpkgs every time the client is updated upstream!
Resolves: #15356
Testing
build-use-sandboxinnix.confon non-NixOS)Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)nix-shell -p nox --run "nox-review wip"./result/bin/)