Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build-pecl: honour nativeBuildInputs #31139

Merged
merged 1 commit into from Nov 2, 2017
Merged

build-pecl: honour nativeBuildInputs #31139

merged 1 commit into from Nov 2, 2017

Conversation

pbogdan
Copy link
Member

@pbogdan pbogdan commented Nov 2, 2017

Otherwise certain extensions are unable to locate pkgconfig.

Motivation for this change

Following tree wide clean up of moving pkgconfig to nativeBuildInputs a number of PHP extensions are currently failing to build.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Otherwise certain extensions are unable to locate pkgconfig.
@Mic92
Copy link
Member

Mic92 commented Nov 2, 2017

Thanks!

@pbogdan pbogdan deleted the fix-build-pecl branch December 3, 2019 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants