Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable/17.09] yara: 3.6.0 -> 3.6.3 (fixes CVE-2017-11328) #31919

Closed
wants to merge 1 commit into from
Closed

[stable/17.09] yara: 3.6.0 -> 3.6.3 (fixes CVE-2017-11328) #31919

wants to merge 1 commit into from

Conversation

andir
Copy link
Member

@andir andir commented Nov 21, 2017 •
edited

Motivation for this change

Fixes Heap-Overflow.

Details at [1].

[1] https://nvd.nist.gov/vuln/detail/CVE-2017-11328

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@andir andir changed the title yara: 3.6.0 -> 3.6.3 (fixes CVE-2017-11328) [stable/17.09] yara: 3.6.0 -> 3.6.3 (fixes CVE-2017-11328) Nov 21, 2017
@vcunat vcunat added 1.severity: security 8.has: port to stable A PR already has a backport to the stable release. labels Nov 22, 2017
vcunat
vcunat reviewed Nov 22, 2017
View reviewed changes
pkgs/tools/security/yara/default.nix
@@ -1,18 +1,18 @@
{ stdenv, fetchFromGitHub, autoconf, automake, libtool, pcre
{ stdenv, fetchpatch, fetchFromGitHub, autoconf, automake, libtool, pcre
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You add fetchpatch and don't use it.

@vcunat
Copy link
Member

vcunat commented Nov 22, 2017

I instead simply picked the commit from master and pushed it as c51a749

@vcunat vcunat closed this Nov 22, 2017
@andir andir deleted the yara-stable branch November 22, 2017 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcunat vcunat vcunat left review comments

Assignees
No one assigned
Labels
1.severity: security 8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@andir @vcunat @GrahamcOfBorg