rdesktop: enable credssp #31921
rdesktop: enable credssp #31921
Conversation
| meta = with stdenv.lib.maintainers; { | ||
| homepage = http://www.citi.umich.edu/projects/nfsv4/linux/; | ||
| description = "Exports a gssapi interface which calls other random gssapi libraries"; | ||
| license = "BSD"; |
There was a problem hiding this comment.
Please use stdenv.lib.licenses.bsd3 here instead of "BSD".
You may also want to bring in "stdenv.lib" instead of "stdenv.lib.maintainers", so you can access license/platforms/maintainers more succinctly within the meta attrset.
There was a problem hiding this comment.
Fixed. I think this is probably the cleanest way to do it.
|
rdesktop closure size increases from 32 to 36 MiB. That's fine. Ack from me. |
corngood
force-pushed
the
rdesktop-krb
branch
from
d3a394f
to
916d1a4
Compare
|
@bjornfor I thought about making credssp optional, but it's enabled by default in configuration, and rdesktop isn't very useful without it. It's probably not worth the complexity. Same goes for making libgssglue modular. |
|
I agree :-) |
|
@GrahamcOfBorg build rdesktop |
There was a problem hiding this comment.
Success for system: x86_64-linux
cp doc/rdesktop.1 /nix/store/877gx518khqydffgar2zkq1ca514fdhx-rdesktop-1.8.3/share/man/man1
chmod 644 /nix/store/877gx518khqydffgar2zkq1ca514fdhx-rdesktop-1.8.3/share/man/man1/rdesktop.1
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/877gx518khqydffgar2zkq1ca514fdhx-rdesktop-1.8.3
shrinking /nix/store/877gx518khqydffgar2zkq1ca514fdhx-rdesktop-1.8.3/bin/rdesktop
gzipping man pages under /nix/store/877gx518khqydffgar2zkq1ca514fdhx-rdesktop-1.8.3/share/man/
stripping (with flags -S) in /nix/store/877gx518khqydffgar2zkq1ca514fdhx-rdesktop-1.8.3/bin
patching script interpreter paths in /nix/store/877gx518khqydffgar2zkq1ca514fdhx-rdesktop-1.8.3
checking for references to /tmp/nix-build-rdesktop-1.8.3.drv-0 in /nix/store/877gx518khqydffgar2zkq1ca514fdhx-rdesktop-1.8.3...
/nix/store/877gx518khqydffgar2zkq1ca514fdhx-rdesktop-1.8.3
|
looks good to me, merging! |
There was a problem hiding this comment.
Failure for system: x86_64-darwin
error: Package ‘rdesktop-1.8.3’ in /tmp/nix-ofborg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/31921/pkgs/applications/networking/remote/rdesktop/default.nix:23 is not supported on ‘x86_64-darwin’, refusing to evaluate.
a) For `nixos-rebuild` you can set
{ nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.
b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
{ allowBroken = true; }
to ~/.config/nixpkgs/config.nix.
Motivation for this change
This allows kerberos authentication in rdesktop, e.g.:
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)