Csu: fix build with CoreFoundation #31917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vcunat This should fix the bootstrap tools. I'm still rebuilding because of a small fix for gcc, but everything looked good apart from that. |
|
I suppose we want to stage it as soon as you [darwin maintainers] think it's ready. The failure would block nixpkgs-unstable channel, so we most likely want a fix before we merge to master, even if it causes a mass rebuild. |
LnL7
commented
Nov 22, 2017
There was a problem hiding this comment.
Adding rpath to /nix/store/paapvpzgkf7snqkw7d2n3gnd7z1603a2-stdenv-bootstrap-tools/lib/libssl.1.0.0.dylib
Adding rpath to /nix/store/paapvpzgkf7snqkw7d2n3gnd7z1603a2-stdenv-bootstrap-tools/lib/libz.1.2.11.dylib
Adding rpath to /nix/store/paapvpzgkf7snqkw7d2n3gnd7z1603a2-stdenv-bootstrap-tools/lib/clang/4.0.1/lib/darwin/libclang_rt.asan_osx_dynamic.dylib
Adding rpath to /nix/store/paapvpzgkf7snqkw7d2n3gnd7z1603a2-stdenv-bootstrap-tools/lib/clang/4.0.1/lib/darwin/libclang_rt.stats_osx_dynamic.dylib
Adding rpath to /nix/store/paapvpzgkf7snqkw7d2n3gnd7z1603a2-stdenv-bootstrap-tools/lib/clang/4.0.1/lib/darwin/libclang_rt.ubsan_osx_dynamic.dylib
Adding rpath to /nix/store/paapvpzgkf7snqkw7d2n3gnd7z1603a2-stdenv-bootstrap-tools/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation
215041 blocks
GrahamcOfBorg
added
10.rebuild-darwin: 0
and removed
10.rebuild-darwin-stdenv
10.rebuild-darwin: 501+
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)