thespian: Python library init at 3.8.3 #31923
Conversation
| # significant system resources. Thespian tests are performed via | ||
| # it's Travis CI configuration and do not need to be duplicated | ||
| # here. | ||
| doCheck = false; |
There was a problem hiding this comment.
The problem is here less the time spent, but that it requires network for most tests.
There was a problem hiding this comment.
Indeed, please update the comment.
| inherit pname version; | ||
| extension = "zip"; | ||
| sha256 = "0vvwsh3waxd5ldrayr86kdcshv07bp361fl7p16g9i044vklwly4"; | ||
| # fdbbea4edb6bad0ac0e53fc7bc6970e78e12eef4944aa4146bcdcb573201676c"; |
| # significant system resources. Thespian tests are performed via | ||
| # it's Travis CI configuration and do not need to be duplicated | ||
| # here. | ||
| doCheck = false; |
There was a problem hiding this comment.
Indeed, please update the comment.
Why not? Do you mean with that, that we don't have to test a package if upstream tests it already? |
|
@FRidh the thespian tests are oriented toward functional testing to verify that the process management and network communications provided by the package are working correctly. During the testing it will create hundreds of processes and use a large number of network ports and corresponding resources. The testing typically takes on the order of 25 minutes to complete. They certainly could be enabled, but it was my thought that this would be either a bad user experience or a high burden on the hydra system already under stress. The comment in question was not intended to absolve of the need for general testing, but rather intended to reassure the viewer that there was testing performed even though it wasn't performed immediately upon installation. Do you have a recommendation for a better approach or better wording? |
|
Ideally a limited amount of testing is done to determine the package is functioning. The absolute minimum would be checking imports, although typically we do not take the effort to implement this, and just have tests disabled. |
Motivation for this change
New package (library for Python).
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)