Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pygmentex: update src #31405

Merged
merged 1 commit into from Nov 8, 2017
Merged

pygmentex: update src #31405

merged 1 commit into from Nov 8, 2017

Conversation

romildo
Copy link
Contributor

@romildo romildo commented Nov 8, 2017

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Mic92 Mic92 merged commit 709c2bf into NixOS:master Nov 8, 2017
@Mic92
Copy link
Member

Mic92 commented Nov 8, 2017

Does this require a backport?

@romildo
Copy link
Contributor Author

romildo commented Nov 8, 2017 •
edited

@Mic92 It stopped building on unstable NixOS with the error message:

unpacking source archive /tmp/nix-build-source.drv-2/pygmentex.zip
suspicious ownership or permission on ‘/nix/store/f7y42xwy0h04xvi2rncnycpd3m7kiv0j-source’; rejecting this build output

I was told on IRC that there has recently been some security changes within nix, to present exploits based on impure file permissions, and the reported error could be related to it.

I fixed it by tagging pygmentex in its repository and downloading directly from it, instead of CTAN.

If this change on nix is backported to 17.09, this fix should also be.

@romildo romildo deleted the fix.pygmentex branch November 8, 2017 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@romildo @Mic92