Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libzip: 1.2.0 -> 1.3.0 #31404

Merged
merged 1 commit into from Nov 9, 2017
Merged

libzip: 1.2.0 -> 1.3.0 #31404

merged 1 commit into from Nov 9, 2017

Conversation

pbogdan
Copy link
Member

@pbogdan pbogdan commented Nov 8, 2017

Motivation for this change

Upstream update available, includes fix for CVE-2017-12858.

Some dependent packages fail to build:

  • CNTK
  • python3.6-CNTK
  • python2.7-CNTK
  • mlt
  • kdenlive

but those are currently broken in master without this change (fix for mlt & kdenlive is in #31402)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@vcunat vcunat added 1.severity: security 9.needs: port to stable A PR needs a backport to the stable release. labels Nov 8, 2017
@vcunat vcunat self-assigned this Nov 9, 2017
@vcunat vcunat merged commit e26c52e into NixOS:master Nov 9, 2017
vcunat added a commit that referenced this pull request Nov 9, 2017
@vcunat
Merge #31404: libzip: security 1.2.0 -> 1.3.0
ea40b0c
vcunat added a commit that referenced this pull request Nov 10, 2017
@vcunat
Merge #31404: libzip: security 1.2.0 -> 1.3.0
78eed74 
(cherry picked from commit ea40b0c)
@vcunat vcunat added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Nov 10, 2017
@pbogdan pbogdan deleted the update-libzip branch December 3, 2019 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcunat vcunat vcunat approved these changes

Assignees

@vcunat vcunat

Labels
1.severity: security 8.has: package (update) 8.has: port to stable A PR already has a backport to the stable release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pbogdan @vcunat @bendlas