Atlassian modules fixes #31408
Merged
Atlassian modules fixes #31408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Properly handle optional configuration. - Use ExecStart/ExecStop instead of script/stopScript.
Only the Oracle JRE is supported by Atlassian appsAtlassian apps (see https://jira.atlassian.com/browse/JRASERVER-46152) Plus Atlassian apps are non free so the switch logic always chose Oracle JRE anyway. Option is kept in case someone want to patch apps to support openjdk.
orivej
approved these changes
Nov 9, 2017
|
Thanks, some stuff wasn't backported from our fork properly apparently, and the openjdk support had been removed recently by atlassian.. |
|
@globin Have you merged using "rebase and merge" option? This does not leave the reference from the commit to the PR, which is often needed for context when reading git history. (I use https://github.com/grosser/git-whence to look up the PR that introduced a commit.) "Rebase and merge --no-ff" would be ideal for pretty and complete git log, but since its not available "Merge pull request" is the only sensible option. |
|
Could this be backported to 17.09 stable? (alongside 0e790b9) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Make Atlassian modules actually work + update to latest versions.
Things done
./result/bin/)