Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

neovim: 0.2.0 -> 0.2.1 #31409

Closed
wants to merge 1 commit into from
Closed

neovim: 0.2.0 -> 0.2.1 #31409

wants to merge 1 commit into from

Conversation

rvolosatovs
Copy link
Member

Motivation for this change

Upstream update

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@teto
Copy link
Member

teto commented Nov 9, 2017

I started some work on pulling the lua test libraries into nixos but that might take some time still. It would be cool if you could add a shellhook to export the embedded lua libraries from .deps/ into LUA_(C)PATH .
Also nvim now guarantee that luajit is available so it should be promoted to a propagatedBuildInput. I don't think there is a need to pass both luajitPackages and luaPackages. We should have only one set, maybe luaPackages and pass callPackage { luaPackages = luajitPackages }.

@garbas
Copy link
Member

garbas commented Nov 10, 2017

@rvolosatovs @teto I extended this PR and updated whole neovim ecosystem of libraries. Could you give it a try before we merge it?

@garbas garbas closed this Nov 10, 2017
@garbas
Copy link
Member

garbas commented Nov 10, 2017

ofcourse it would be nice to mention the number of the PR :)

#31460

@rvolosatovs rvolosatovs deleted the update/neovim branch April 16, 2018 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (update) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@rvolosatovs @teto @garbas @c0bw3b @GrahamcOfBorg